Code style cleanups

Add keyword arguments. Sort arguments and models.
Move literals to their own module. Prepend handler_ to
signal handlers.

Signed-off-by: Roberto Rosario <roberto.rosario.gonzalez@gmail.com>
This commit is contained in:
Roberto Rosario
2019-04-26 03:32:35 -04:00
parent 20acc24c7f
commit 74c97314d7
160 changed files with 1029 additions and 972 deletions

View File

@@ -37,7 +37,7 @@ class DocumentCommentsApp(MayanAppConfig):
app_label='documents', model_name='Document'
)
Comment = self.get_model('Comment')
Comment = self.get_model(model_name='Comment')
ModelEventType.register(
model=Document, event_types=(
@@ -52,12 +52,12 @@ class DocumentCommentsApp(MayanAppConfig):
)
)
SourceColumn(source=Comment, label=_('Date'), attribute='submit_date')
SourceColumn(attribute='submit_date', source=Comment)
SourceColumn(
source=Comment, label=_('User'),
func=lambda context: context['object'].user.get_full_name() if context['object'].user.get_full_name() else context['object'].user
func=lambda context: context['object'].user.get_full_name() if context['object'].user.get_full_name() else context['object'].user,
source=Comment
)
SourceColumn(source=Comment, label=_('Comment'), attribute='comment')
SourceColumn(attribute='comment', source=Comment)
document_page_search.add_model_field(
field='document_version__document__comments__comment',