Implement document workflows transition ACLs. GitLab issue #321.
Signed-off-by: Roberto Rosario <roberto.rosario.gonzalez@gmail.com>
This commit is contained in:
Roberto Rosario
@@ -5,20 +5,24 @@ from django.core.urlresolvers import reverse
|
||||
from django.test.client import Client
|
||||
from django.test import TestCase
|
||||
|
||||
from acls.models import AccessControlList
|
||||
from documents.models import DocumentType
|
||||
from documents.tests.literals import (
|
||||
TEST_DOCUMENT_TYPE, TEST_SMALL_DOCUMENT_PATH
|
||||
)
|
||||
from documents.tests.test_views import GenericDocumentViewTestCase
|
||||
from user_management.tests import (
|
||||
TEST_ADMIN_PASSWORD, TEST_ADMIN_USERNAME, TEST_ADMIN_EMAIL
|
||||
)
|
||||
|
||||
from ..models import Workflow, WorkflowState, WorkflowTransition
|
||||
from ..permissions import permission_workflow_transition
|
||||
|
||||
from .literals import (
|
||||
TEST_WORKFLOW_LABEL, TEST_WORKFLOW_INITIAL_STATE_LABEL,
|
||||
TEST_WORKFLOW_INITIAL_STATE_COMPLETION, TEST_WORKFLOW_STATE_LABEL,
|
||||
TEST_WORKFLOW_STATE_COMPLETION, TEST_WORKFLOW_TRANSITION_LABEL
|
||||
TEST_WORKFLOW_STATE_COMPLETION, TEST_WORKFLOW_TRANSITION_LABEL,
|
||||
TEST_WORKFLOW_TRANSITION_LABEL_2
|
||||
)
|
||||
|
||||
|
||||
@@ -48,6 +52,26 @@ class DocumentStateViewTestCase(TestCase):
|
||||
def tearDown(self):
|
||||
self.document_type.delete()
|
||||
|
||||
def _create_workflow(self):
|
||||
self.workflow = Workflow.objects.create(label=TEST_WORKFLOW_LABEL)
|
||||
|
||||
def _create_workflow_states(self):
|
||||
self.workflow_initial_state = WorkflowState.objects.create(
|
||||
workflow=self.workflow, label=TEST_WORKFLOW_INITIAL_STATE_LABEL,
|
||||
completion=TEST_WORKFLOW_INITIAL_STATE_COMPLETION, initial=True
|
||||
)
|
||||
self.workflow_state = WorkflowState.objects.create(
|
||||
workflow=self.workflow, label=TEST_WORKFLOW_STATE_LABEL,
|
||||
completion=TEST_WORKFLOW_STATE_COMPLETION
|
||||
)
|
||||
|
||||
def _create_workflow_transition(self):
|
||||
self.workflow_transition = WorkflowTransition.objects.create(
|
||||
workflow=self.workflow, label=TEST_WORKFLOW_TRANSITION_LABEL,
|
||||
origin_state=self.workflow_initial_state,
|
||||
destination_state=self.workflow_state
|
||||
)
|
||||
|
||||
def test_creating_workflow(self):
|
||||
response = self.client.post(
|
||||
reverse(
|
||||
@@ -63,14 +87,12 @@ class DocumentStateViewTestCase(TestCase):
|
||||
self.assertEquals(Workflow.objects.all()[0].label, TEST_WORKFLOW_LABEL)
|
||||
|
||||
def test_delete_workflow(self):
|
||||
workflow = Workflow.objects.create(label=TEST_WORKFLOW_LABEL)
|
||||
|
||||
self.assertEquals(Workflow.objects.count(), 1)
|
||||
self.assertEquals(Workflow.objects.all()[0].label, TEST_WORKFLOW_LABEL)
|
||||
self._create_workflow()
|
||||
|
||||
response = self.client.post(
|
||||
reverse(
|
||||
'document_states:setup_workflow_delete', args=(workflow.pk,)
|
||||
'document_states:setup_workflow_delete',
|
||||
args=(self.workflow.pk,)
|
||||
), follow=True
|
||||
)
|
||||
|
||||
@@ -79,12 +101,12 @@ class DocumentStateViewTestCase(TestCase):
|
||||
self.assertEquals(Workflow.objects.count(), 0)
|
||||
|
||||
def test_create_workflow_state(self):
|
||||
workflow = Workflow.objects.create(label=TEST_WORKFLOW_LABEL)
|
||||
self._create_workflow()
|
||||
|
||||
response = self.client.post(
|
||||
reverse(
|
||||
'document_states:setup_workflow_state_create',
|
||||
args=(workflow.pk,)
|
||||
args=(self.workflow.pk,)
|
||||
), data={
|
||||
'label': TEST_WORKFLOW_STATE_LABEL,
|
||||
'completion': TEST_WORKFLOW_STATE_COMPLETION,
|
||||
@@ -103,43 +125,33 @@ class DocumentStateViewTestCase(TestCase):
|
||||
)
|
||||
|
||||
def test_delete_workflow_state(self):
|
||||
workflow = Workflow.objects.create(label=TEST_WORKFLOW_LABEL)
|
||||
workflow_state = WorkflowState.objects.create(
|
||||
workflow=workflow, label=TEST_WORKFLOW_STATE_LABEL,
|
||||
completion=TEST_WORKFLOW_STATE_COMPLETION
|
||||
)
|
||||
self._create_workflow()
|
||||
self._create_workflow_states()
|
||||
|
||||
response = self.client.post(
|
||||
reverse(
|
||||
'document_states:setup_workflow_state_delete',
|
||||
args=(workflow_state.pk,)
|
||||
args=(self.workflow_state.pk,)
|
||||
), follow=True
|
||||
)
|
||||
|
||||
self.assertEquals(response.status_code, 200)
|
||||
|
||||
self.assertEquals(WorkflowState.objects.count(), 0)
|
||||
self.assertEquals(WorkflowState.objects.count(), 1)
|
||||
self.assertEquals(Workflow.objects.count(), 1)
|
||||
|
||||
def test_create_workflow_transition(self):
|
||||
workflow = Workflow.objects.create(label=TEST_WORKFLOW_LABEL)
|
||||
workflow_initial_state = WorkflowState.objects.create(
|
||||
workflow=workflow, label=TEST_WORKFLOW_INITIAL_STATE_LABEL,
|
||||
completion=TEST_WORKFLOW_INITIAL_STATE_COMPLETION, initial=True
|
||||
)
|
||||
workflow_state = WorkflowState.objects.create(
|
||||
workflow=workflow, label=TEST_WORKFLOW_STATE_LABEL,
|
||||
completion=TEST_WORKFLOW_STATE_COMPLETION
|
||||
)
|
||||
self._create_workflow()
|
||||
self._create_workflow_states()
|
||||
|
||||
response = self.client.post(
|
||||
reverse(
|
||||
'document_states:setup_workflow_transition_create',
|
||||
args=(workflow.pk,)
|
||||
args=(self.workflow.pk,)
|
||||
), data={
|
||||
'label': TEST_WORKFLOW_TRANSITION_LABEL,
|
||||
'origin_state': workflow_initial_state.pk,
|
||||
'destination_state': workflow_state.pk,
|
||||
'origin_state': self.workflow_initial_state.pk,
|
||||
'destination_state': self.workflow_state.pk,
|
||||
}, follow=True
|
||||
)
|
||||
|
||||
@@ -152,35 +164,22 @@ class DocumentStateViewTestCase(TestCase):
|
||||
)
|
||||
self.assertEquals(
|
||||
WorkflowTransition.objects.all()[0].origin_state,
|
||||
workflow_initial_state
|
||||
self.workflow_initial_state
|
||||
)
|
||||
self.assertEquals(
|
||||
WorkflowTransition.objects.all()[0].destination_state,
|
||||
workflow_state
|
||||
self.workflow_state
|
||||
)
|
||||
|
||||
def test_delete_workflow_transition(self):
|
||||
workflow = Workflow.objects.create(label=TEST_WORKFLOW_LABEL)
|
||||
workflow_initial_state = WorkflowState.objects.create(
|
||||
workflow=workflow, label=TEST_WORKFLOW_INITIAL_STATE_LABEL,
|
||||
completion=TEST_WORKFLOW_INITIAL_STATE_COMPLETION, initial=True
|
||||
)
|
||||
workflow_state = WorkflowState.objects.create(
|
||||
workflow=workflow, label=TEST_WORKFLOW_STATE_LABEL,
|
||||
completion=TEST_WORKFLOW_STATE_COMPLETION
|
||||
)
|
||||
workflow_transition = WorkflowTransition.objects.create(
|
||||
workflow=workflow, label=TEST_WORKFLOW_TRANSITION_LABEL,
|
||||
origin_state=workflow_initial_state,
|
||||
destination_state=workflow_state
|
||||
)
|
||||
|
||||
self.assertEquals(WorkflowTransition.objects.count(), 1)
|
||||
self._create_workflow()
|
||||
self._create_workflow_states()
|
||||
self._create_workflow_transition()
|
||||
|
||||
response = self.client.post(
|
||||
reverse(
|
||||
'document_states:setup_workflow_transition_delete',
|
||||
args=(workflow_transition.pk,)
|
||||
args=(self.workflow_transition.pk,)
|
||||
), follow=True
|
||||
)
|
||||
|
||||
@@ -189,3 +188,152 @@ class DocumentStateViewTestCase(TestCase):
|
||||
self.assertEquals(WorkflowState.objects.count(), 2)
|
||||
self.assertEquals(Workflow.objects.count(), 1)
|
||||
self.assertEquals(WorkflowTransition.objects.count(), 0)
|
||||
|
||||
|
||||
class DocumentStateTransitionViewTestCase(GenericDocumentViewTestCase):
|
||||
def _create_workflow(self):
|
||||
self.workflow = Workflow.objects.create(label=TEST_WORKFLOW_LABEL)
|
||||
self.workflow.document_types.add(self.document_type)
|
||||
|
||||
def _create_workflow_states(self):
|
||||
self.workflow_initial_state = WorkflowState.objects.create(
|
||||
workflow=self.workflow, label=TEST_WORKFLOW_INITIAL_STATE_LABEL,
|
||||
completion=TEST_WORKFLOW_INITIAL_STATE_COMPLETION, initial=True
|
||||
)
|
||||
self.workflow_state = WorkflowState.objects.create(
|
||||
workflow=self.workflow, label=TEST_WORKFLOW_STATE_LABEL,
|
||||
completion=TEST_WORKFLOW_STATE_COMPLETION
|
||||
)
|
||||
|
||||
def _create_workflow_transitions(self):
|
||||
self.workflow_transition = WorkflowTransition.objects.create(
|
||||
workflow=self.workflow, label=TEST_WORKFLOW_TRANSITION_LABEL,
|
||||
origin_state=self.workflow_initial_state,
|
||||
destination_state=self.workflow_state
|
||||
)
|
||||
|
||||
self.workflow_transition_2 = WorkflowTransition.objects.create(
|
||||
workflow=self.workflow, label=TEST_WORKFLOW_TRANSITION_LABEL_2,
|
||||
origin_state=self.workflow_initial_state,
|
||||
destination_state=self.workflow_state
|
||||
)
|
||||
|
||||
def _create_document(self):
|
||||
with open(TEST_SMALL_DOCUMENT_PATH) as file_object:
|
||||
self.document_2 = self.document_type.new_document(
|
||||
file_object=file_object
|
||||
)
|
||||
|
||||
def _request_workflow_transition(self, workflow_instance):
|
||||
return self.post(
|
||||
'document_states:workflow_instance_transition',
|
||||
args=(workflow_instance.pk,), data={
|
||||
'transition': self.workflow_transition.pk,
|
||||
}
|
||||
)
|
||||
|
||||
def test_transition_workflow_no_permission(self):
|
||||
self.login_user()
|
||||
self._create_workflow()
|
||||
self._create_workflow_states()
|
||||
self._create_workflow_transitions()
|
||||
self._create_document()
|
||||
|
||||
workflow_instance = self.document_2.workflows.first()
|
||||
|
||||
response = self._request_workflow_transition(
|
||||
workflow_instance=workflow_instance
|
||||
)
|
||||
|
||||
self.assertEqual(response.status_code, 200)
|
||||
|
||||
# Workflow should remain in the same initial state
|
||||
self.assertEqual(
|
||||
workflow_instance.get_current_state(), self.workflow_initial_state
|
||||
)
|
||||
|
||||
def test_transition_workflow_with_permission(self):
|
||||
"""
|
||||
Test transitioning a workflow by granting the transition workflow
|
||||
permission to the role.
|
||||
"""
|
||||
|
||||
self.login_user()
|
||||
self._create_workflow()
|
||||
self._create_workflow_states()
|
||||
self._create_workflow_transitions()
|
||||
self._create_document()
|
||||
|
||||
workflow_instance = self.document_2.workflows.first()
|
||||
|
||||
self.grant(permission_workflow_transition)
|
||||
response = self._request_workflow_transition(
|
||||
workflow_instance=workflow_instance
|
||||
)
|
||||
|
||||
self.assertEqual(response.status_code, 302)
|
||||
|
||||
# Workflow should remain in the same initial state
|
||||
self.assertEqual(
|
||||
workflow_instance.get_current_state(), self.workflow_state
|
||||
)
|
||||
|
||||
def test_transition_workflow_with_workflow_acl(self):
|
||||
"""
|
||||
Test transitioning a workflow by granting the transition workflow
|
||||
permission to the workflow itself via ACL.
|
||||
"""
|
||||
|
||||
self.login_user()
|
||||
self._create_workflow()
|
||||
self._create_workflow_states()
|
||||
self._create_workflow_transitions()
|
||||
self._create_document()
|
||||
|
||||
workflow_instance = self.document_2.workflows.first()
|
||||
|
||||
acl = AccessControlList.objects.create(
|
||||
content_object=self.workflow, role=self.role
|
||||
)
|
||||
acl.permissions.add(permission_workflow_transition.stored_permission)
|
||||
|
||||
response = self._request_workflow_transition(
|
||||
workflow_instance=workflow_instance
|
||||
)
|
||||
|
||||
self.assertEqual(response.status_code, 302)
|
||||
|
||||
# Workflow should remain in the same initial state
|
||||
self.assertEqual(
|
||||
workflow_instance.get_current_state(), self.workflow_state
|
||||
)
|
||||
|
||||
def test_transition_workflow_with_transition_acl(self):
|
||||
"""
|
||||
Test transitioning a workflow by granting the transition workflow
|
||||
permission to the transition via ACL.
|
||||
"""
|
||||
|
||||
self.login_user()
|
||||
self._create_workflow()
|
||||
self._create_workflow_states()
|
||||
self._create_workflow_transitions()
|
||||
self._create_document()
|
||||
|
||||
workflow_instance = self.document_2.workflows.first()
|
||||
|
||||
acl = AccessControlList.objects.create(
|
||||
content_object=self.workflow_transition, role=self.role
|
||||
)
|
||||
acl.permissions.add(permission_workflow_transition.stored_permission)
|
||||
|
||||
response = self._request_workflow_transition(
|
||||
workflow_instance=workflow_instance
|
||||
)
|
||||
|
||||
self.assertEqual(response.status_code, 302)
|
||||
|
||||
# Workflow should remain in the same initial state
|
||||
self.assertEqual(
|
||||
workflow_instance.get_current_state(), self.workflow_state
|
||||
)
|
||||
|
||||
Reference in New Issue
Block a user