Remove support for 'hidden' smart settings

This commit is contained in:
Roberto Rosario
2015-06-22 01:18:38 -04:00
parent 50e547dc98
commit 6dcb984aca
2 changed files with 26 additions and 17 deletions

View File

@@ -8,7 +8,7 @@ register_settings(
namespace='dynamic_search',
module='dynamic_search.settings',
settings=[
{'name': 'SHOW_OBJECT_TYPE', 'global_name': 'SEARCH_SHOW_OBJECT_TYPE', 'default': True, 'hidden': True},
{'name': 'SHOW_OBJECT_TYPE', 'global_name': 'SEARCH_SHOW_OBJECT_TYPE', 'default': True},
{'name': 'LIMIT', 'global_name': 'SEARCH_LIMIT', 'default': 100, 'description': _('Maximum amount search hits to fetch and display.')},
{'name': 'RECENT_COUNT', 'global_name': 'SEARCH_RECENT_COUNT', 'default': 5, 'description': _('Maximum number of search queries to remember per user.')},
]

View File

@@ -16,7 +16,6 @@ def setting_list(request):
new_settings = []
for namespace, sub_settings in settings.items():
for sub_setting in sub_settings:
if not sub_setting.get('hidden', False):
new_settings.append({
'module': sub_setting['module'],
'name': sub_setting['name'],
@@ -32,15 +31,25 @@ def setting_list(request):
'hide_link': True,
'hide_object': True,
'extra_columns': [
{'name': _('Name'), 'attribute': encapsulate(lambda x: mark_safe('<span style="font-weight: bold;">%s</span><br />%s' % (x.get('global_name'), x.get('description'))))},
{
'name': _('Value'), 'attribute': encapsulate(lambda x: mark_safe('<div class="nowrap">%s&nbsp;%s</div>' % (
'name': _('Name'),
'attribute': encapsulate(lambda x: mark_safe('<span style="font-weight: bold;">%s</span><br />%s' % (x.get('global_name'), x.get('description'))))
},
{
'name': _('Value'),
'attribute': encapsulate(
lambda x: mark_safe(
'<div class="nowrap">%s&nbsp;%s</div>' % (
return_type(getattr(x['module'], x['name'])),
exists_widget(getattr(x['module'], x['name'])) if x['exists'] else ''
)))
)
)
)
},
]
}
return render_to_response('appearance/generic_list.html', context,
context_instance=RequestContext(request))
return render_to_response(
'appearance/generic_list.html', context,
context_instance=RequestContext(request)
)