Reorganize reusable test code

Extract test views and user code into their own separate test case
mixins. Append TestCase to test case mixins with base test code
to differentiate them from test mixins with reusable view calls.

Signed-off-by: Roberto Rosario <Roberto.Rosario@mayan-edms.com>

mayan/apps/common/tests/base.py

@@ -1,30 +1,21 @@
 from __future__ import absolute_import, unicode_literals
 
-from django.conf.urls import url
-from django.contrib.auth import get_user_model
-from django.http import HttpResponse
-from django.template import Context, Template
 from django.test import TestCase
-from django.test.utils import ContextList
-from django.urls import clear_url_caches, reverse
+from django.urls import reverse
 from django_downloadview import assert_download_response
 
-from mayan.apps.acls.tests.mixins import ACLBaseTestMixin
+from mayan.apps.acls.tests.mixins import ACLTestCaseMixin
 from mayan.apps.permissions.classes import Permission
 from mayan.apps.smart_settings.classes import Namespace
-from mayan.apps.user_management.tests import (
-    TEST_ADMIN_PASSWORD, TEST_ADMIN_USERNAME, TEST_USER_PASSWORD,
-    TEST_USER_USERNAME
-)
 
-from .literals import TEST_VIEW_NAME, TEST_VIEW_URL
 from .mixins import (
-    ContentTypeCheckMixin, DatabaseConversionMixin, OpenFileCheckMixin,
-    TempfileCheckMixin
+    ClientMethodsTestCaseMixin, ContentTypeCheckMixin, DatabaseConversionMixin,
+    OpenFileCheckTestCaseMixin, TempfileCheckTestCaseMixin,
+    TestViewTestCaseMixin
 )
 
 
-class BaseTestCase(DatabaseConversionMixin, ACLBaseTestMixin, ContentTypeCheckMixin, OpenFileCheckMixin, TempfileCheckMixin, TestCase):
+class BaseTestCase(DatabaseConversionMixin, ACLTestCaseMixin, ContentTypeCheckMixin, OpenFileCheckTestCaseMixin, TempfileCheckTestCaseMixin, TestCase):
     """
     This is the most basic test case class any test in the project should use.
     """
@@ -36,76 +27,9 @@ class BaseTestCase(DatabaseConversionMixin, ACLBaseTestMixin, ContentTypeCheckMi
         Permission.invalidate_cache()
 
 
-class GenericViewTestCase(BaseTestCase):
-    has_test_view = False
-
-    def tearDown(self):
-        from mayan.urls import urlpatterns
-
-        self.client.logout()
-        if self.has_test_view:
-            urlpatterns.pop(0)
-        super(GenericViewTestCase, self).tearDown()
-
-    def add_test_view(self, test_object):
-        from mayan.urls import urlpatterns
-
-        def test_view(request):
-            template = Template('{{ object }}')
-            context = Context(
-                {'object': test_object, 'resolved_object': test_object}
-            )
-            return HttpResponse(template.render(context=context))
-
-        urlpatterns.insert(0, url(TEST_VIEW_URL, test_view, name=TEST_VIEW_NAME))
-        clear_url_caches()
-        self.has_test_view = True
-
-    def get_test_view(self):
-        response = self.get(TEST_VIEW_NAME)
-        if isinstance(response.context, ContextList):
-            # template widget rendering causes test client response to be
-            # ContextList rather than RequestContext. Typecast to dictionary
-            # before updating.
-            result = dict(response.context).copy()
-            result.update({'request': response.wsgi_request})
-            return Context(result)
-        else:
-            response.context.update({'request': response.wsgi_request})
-            return Context(response.context)
-
-    def get(self, viewname=None, path=None, *args, **kwargs):
-        data = kwargs.pop('data', {})
-        follow = kwargs.pop('follow', False)
-
-        if viewname:
-            path = reverse(viewname=viewname, *args, **kwargs)
-
-        return self.client.get(
-            path=path, data=data, follow=follow
-        )
-
-    def login(self, *args, **kwargs):
-        logged_in = self.client.login(*args, **kwargs)
-
-        return logged_in
-
-    def login_user(self):
-        self.login(username=TEST_USER_USERNAME, password=TEST_USER_PASSWORD)
-
-    def login_admin_user(self):
-        self.login(username=TEST_ADMIN_USERNAME, password=TEST_ADMIN_PASSWORD)
-
-    def logout(self):
-        self.client.logout()
-
-    def post(self, viewname=None, path=None, *args, **kwargs):
-        data = kwargs.pop('data', {})
-        follow = kwargs.pop('follow', False)
-
-        if viewname:
-            path = reverse(viewname=viewname, *args, **kwargs)
-
-        return self.client.post(
-            path=path, data=data, follow=follow
-        )
+class GenericViewTestCase(ClientMethodsTestCaseMixin, TestViewTestCaseMixin, BaseTestCase):
+    """
+    A generic view test case built on top of the base test case providing
+    single user test view to test object resolution and shorthand HTTP
+    method functions.
+    """