matthias/mayan-edms
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Reorganize the way the document print view checks for permission to move permission checking to the dispatch method.

Browse Source 
Signed-off-by: Roberto Rosario <roberto.rosario.gonzalez@gmail.com>
This commit is contained in:
Roberto Rosario
2018-04-03 04:05:19 -04:00
parent fc560fe63a
commit 5fa0dc8d0d
1 changed files with 9 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
mayan/apps/documents/views/document_views.py
View File

@@ -718,6 +718,14 @@ class DocumentPrint(FormView):
form_class = DocumentPrintForm form_class = DocumentPrintForm
def dispatch(self, request, *args, **kwargs): def dispatch(self, request, *args, **kwargs):
instance = self.get_object()
AccessControlList.objects.check_access(
permissions=permission_document_print, user=self.request.user,
obj=instance
)
instance.add_as_recent_document_for_user(self.request.user)
self.page_group = self.request.GET.get('page_group') self.page_group = self.request.GET.get('page_group')
self.page_range = self.request.GET.get('page_range') self.page_range = self.request.GET.get('page_range')
return super(DocumentPrint, self).dispatch(request, *args, **kwargs) return super(DocumentPrint, self).dispatch(request, *args, **kwargs)
@@ -767,16 +775,7 @@ class DocumentPrint(FormView):
return context return context
def get_object(self): def get_object(self):
instance = get_object_or_404(Document, pk=self.kwargs['pk']) return get_object_or_404(Document, pk=self.kwargs['pk'])
AccessControlList.objects.check_access(
permissions=permission_document_print, user=self.request.user,
obj=instance
)
instance.add_as_recent_document_for_user(self.request.user)
return instance
def get_template_names(self): def get_template_names(self):
if self.page_group or self.page_range: if self.page_group or self.page_range: