From 5f9a0522360aab783615a6008e03e5323ca50052 Mon Sep 17 00:00:00 2001 From: Roberto Rosario Date: Thu, 13 Jul 2017 18:21:02 -0400 Subject: [PATCH] Improve wizard upload view test. Signed-off-by: Roberto Rosario --- mayan/apps/documents/tests/literals.py | 4 ++-- mayan/apps/sources/tests/test_views.py | 30 +++++++++++++------------- 2 files changed, 17 insertions(+), 17 deletions(-) diff --git a/mayan/apps/documents/tests/literals.py b/mayan/apps/documents/tests/literals.py index 36f860848f..16a877af0e 100644 --- a/mayan/apps/documents/tests/literals.py +++ b/mayan/apps/documents/tests/literals.py @@ -15,8 +15,8 @@ __all__ = ( 'TEST_NON_ASCII_COMPRESSED_DOCUMENT_FILENAME', 'TEST_NON_ASCII_COMPRESSED_DOCUMENT_PATH', 'TEST_NON_ASCII_DOCUMENT_FILENAME', 'TEST_NON_ASCII_DOCUMENT_PATH', - 'TEST_SMALL_DOCUMENT_FILENAME', 'TEST_SMALL_DOCUMENT_PATH', - 'TEST_DOCUMENT_VERSION_COMMENT_EDITED', + 'TEST_SMALL_DOCUMENT_CHECKSUM', 'TEST_SMALL_DOCUMENT_FILENAME', + 'TEST_SMALL_DOCUMENT_PATH', 'TEST_DOCUMENT_VERSION_COMMENT_EDITED', ) # Filenames diff --git a/mayan/apps/sources/tests/test_views.py b/mayan/apps/sources/tests/test_views.py index ed2e5c2590..41d5131a16 100644 --- a/mayan/apps/sources/tests/test_views.py +++ b/mayan/apps/sources/tests/test_views.py @@ -12,8 +12,8 @@ from common.utils import fs_cleanup, mkdtemp from documents.models import Document, DocumentType from documents.permissions import permission_document_create from documents.tests import ( - TEST_DOCUMENT_PATH, TEST_SMALL_DOCUMENT_PATH, TEST_DOCUMENT_DESCRIPTION, - TEST_DOCUMENT_TYPE + TEST_DOCUMENT_DESCRIPTION, TEST_DOCUMENT_PATH, TEST_DOCUMENT_TYPE, + TEST_SMALL_DOCUMENT_CHECKSUM, TEST_SMALL_DOCUMENT_PATH ) from documents.tests.test_views import GenericDocumentViewTestCase @@ -40,17 +40,20 @@ class DocumentUploadTestCase(GenericDocumentViewTestCase): self.document.delete() - def test_upload_wizard_without_permission(self): - self.login_user() - - with open(TEST_DOCUMENT_PATH) as file_object: - response = self.post( + def _request_upload_wizard(self): + with open(TEST_SMALL_DOCUMENT_PATH) as file_object: + return self.post( 'sources:upload_interactive', args=(self.source.pk,), data={ 'source-file': file_object, 'document_type_id': self.document_type.pk, - } + }, follow=True ) + def test_upload_wizard_without_permission(self): + self.login_user() + + response = self._request_upload_wizard() + self.assertEqual(response.status_code, 403) self.assertEqual(Document.objects.count(), 0) @@ -59,16 +62,13 @@ class DocumentUploadTestCase(GenericDocumentViewTestCase): self.grant(permission_document_create) - with open(TEST_DOCUMENT_PATH) as file_object: - response = self.post( - 'sources:upload_interactive', args=(self.source.pk,), data={ - 'source-file': file_object, - 'document_type_id': self.document_type.pk, - }, follow=True - ) + response = self._request_upload_wizard() self.assertTrue(b'queued' in response.content) self.assertEqual(Document.objects.count(), 1) + self.assertEqual( + Document.objects.first().checksum, TEST_SMALL_DOCUMENT_CHECKSUM + ) def test_upload_wizard_with_document_type_access(self): """