matthias/mayan-edms
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Replace unnecessary lists with tuples.

Browse Source
This commit is contained in:
Roberto Rosario
2015-07-28 00:49:07 -04:00
parent 1e746c700a
commit 54f3cef7ba
14 changed files with 93 additions and 88 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
mayan/apps/document_comments/apps.py
View File

@@ -45,7 +45,9 @@ class DocumentCommentsApp(MayanAppConfig):
SourceColumn(source=Comment, label=_('Date'), attribute='submit_date')
SourceColumn(
source=Comment, label=_('User'),
attribute=encapsulate(lambda x: x.user.get_full_name() if x.user.get_full_name() else x.user)
attribute=encapsulate(
lambda x: x.user.get_full_name() if x.user.get_full_name() else x.user
)
)
SourceColumn(source=Comment, label=_('Comment'), attribute='comment')
@@ -57,13 +59,13 @@ class DocumentCommentsApp(MayanAppConfig):
)
menu_sidebar.bind_links(
links=[link_comment_add],
sources=[
links=(link_comment_add,),
sources=(
'comments:comments_for_document', 'comments:comment_add',
'comments:comment_delete', 'comments:comment_multiple_delete'
]
)
)
menu_object.bind_links(links=[link_comment_delete], sources=[Comment])
menu_object.bind_links(links=(link_comment_delete,), sources=(Comment,))
menu_facet.bind_links(
links=[link_comments_for_document], sources=[Document]
links=(link_comments_for_document,), sources=(Document,)
)

8
mayan/apps/document_comments/links.py
View File

@@ -10,18 +10,18 @@ from .permissions import (
)
link_comment_add = Link(
permissions=[permission_comment_create], text=_('Add comment'),
permissions=(permission_comment_create,), text=_('Add comment'),
view='comments:comment_add', args='object.pk'
)
link_comment_delete = Link(
permissions=[permission_comment_delete], tags='dangerous',
permissions=(permission_comment_delete,), tags='dangerous',
text=_('Delete'), view='comments:comment_delete', args='object.pk'
)
link_comment_multiple_delete = Link(
permissions=[permission_comment_delete], tags='dangerous',
permissions=(permission_comment_delete,), tags='dangerous',
text=_('Delete'), view='comments:comment_multiple_delete', args='object.pk'
)
link_comments_for_document = Link(
permissions=[permission_comment_view], text=_('Comments'),
permissions=(permission_comment_view,), text=_('Comments'),
view='comments:comments_for_document', args='object.pk'
)