Merge branch 'new_metadata'
Conflicts: requirements/development.txt requirements/production.txt settings.py
This commit is contained in:
@@ -1,8 +1,5 @@
|
||||
#from django.contrib.auth.models import User
|
||||
#from django.contrib.auth.models import Group
|
||||
from django.db.utils import DatabaseError
|
||||
from django.shortcuts import get_object_or_404
|
||||
from django.contrib.contenttypes.models import ContentType
|
||||
from django.utils.translation import ugettext_lazy as _
|
||||
from django.utils.translation import ugettext
|
||||
from django.core.exceptions import PermissionDenied
|
||||
@@ -11,7 +8,7 @@ from permissions import PERMISSION_ROLE_VIEW, PERMISSION_ROLE_EDIT, \
|
||||
PERMISSION_ROLE_CREATE, PERMISSION_ROLE_DELETE, \
|
||||
PERMISSION_PERMISSION_GRANT, PERMISSION_PERMISSION_REVOKE
|
||||
|
||||
from permissions.models import Permission, Role
|
||||
from permissions.models import Permission
|
||||
|
||||
|
||||
def register_permissions(namespace, permissions):
|
||||
|
||||
@@ -2,7 +2,7 @@ from django.db import models
|
||||
from django.utils.translation import ugettext_lazy as _
|
||||
from django.contrib.contenttypes.models import ContentType
|
||||
from django.contrib.contenttypes import generic
|
||||
from django.contrib.auth.models import User, Group
|
||||
from django.contrib.auth.models import User
|
||||
|
||||
|
||||
class PermissionManager(models.Manager):
|
||||
@@ -26,10 +26,10 @@ class Permission(models.Model):
|
||||
|
||||
def __unicode__(self):
|
||||
return self.label
|
||||
|
||||
|
||||
def get_holders(self):
|
||||
return [holder.holder_object for holder in self.permissionholder_set.all()]
|
||||
|
||||
|
||||
def has_permission(self, requester):
|
||||
if isinstance(requester, User):
|
||||
if requester.is_superuser or requester.is_staff:
|
||||
@@ -38,8 +38,8 @@ class Permission(models.Model):
|
||||
# Request is one of the permission's holders?
|
||||
if requester in self.get_holders():
|
||||
return True
|
||||
|
||||
# If not check if the requesters memberships objects is one of
|
||||
|
||||
# If not check if the requesters memberships objects is one of
|
||||
# the permission's holder?
|
||||
roles = RoleMember.objects.get_roles_for_member(requester)
|
||||
|
||||
@@ -47,7 +47,7 @@ class Permission(models.Model):
|
||||
groups = requester.groups.all()
|
||||
else:
|
||||
groups = []
|
||||
|
||||
|
||||
for membership in list(set(roles) | set(groups)):
|
||||
if self.has_permission(membership):
|
||||
return True
|
||||
|
||||
+45
-80
@@ -1,4 +1,5 @@
|
||||
from django.utils.translation import ugettext_lazy as _
|
||||
from django.utils.translation import ugettext
|
||||
from django.http import HttpResponseRedirect
|
||||
from django.shortcuts import render_to_response, get_object_or_404
|
||||
from django.template import RequestContext
|
||||
@@ -10,7 +11,7 @@ from django.contrib.contenttypes.models import ContentType
|
||||
from django.core.exceptions import ObjectDoesNotExist
|
||||
from django.contrib.auth.models import User, Group
|
||||
|
||||
from common.forms import ChoiceForm
|
||||
from common.views import assign_remove
|
||||
from common.utils import generate_choices_w_labels
|
||||
|
||||
from permissions.models import Role, Permission, PermissionHolder, RoleMember
|
||||
@@ -38,18 +39,18 @@ def role_list(request):
|
||||
def _role_permission_link(requester, permission, permission_list):
|
||||
ct = ContentType.objects.get_for_model(requester)
|
||||
|
||||
template = '<span class="nowrap"><a href="%(url)s"><span class="famfam active famfam-%(icon)s"></span>%(text)s</a></span>'
|
||||
template = u'<span class="nowrap"><a href="%(url)s"><span class="famfam active famfam-%(icon)s"></span>%(text)s</a></span>'
|
||||
|
||||
if permission in permission_list:
|
||||
return template % {
|
||||
'url': reverse('permission_revoke',
|
||||
args=[permission.id, ct.app_label, ct.model, requester.id]),
|
||||
'icon': 'delete', 'text': _(u'Revoke')}
|
||||
args=[permission.pk, ct.app_label, ct.model, requester.pk]),
|
||||
'icon': u'delete', 'text': ugettext(u'Revoke')}
|
||||
else:
|
||||
return template % {
|
||||
'url': reverse('permission_grant',
|
||||
args=[permission.id, ct.app_label, ct.model, requester.id]),
|
||||
'icon': 'add', 'text': _(u'Grant')}
|
||||
args=[permission.pk, ct.app_label, ct.model, requester.pk]),
|
||||
'icon': u'add', 'text': ugettext(u'Grant')}
|
||||
|
||||
|
||||
def role_permissions(request, role_id):
|
||||
@@ -61,20 +62,20 @@ def role_permissions(request, role_id):
|
||||
role_permissions_list = Permission.objects.get_for_holder(role)
|
||||
subtemplates_list = [
|
||||
{
|
||||
'name':'generic_list_subtemplate.html',
|
||||
'name': u'generic_list_subtemplate.html',
|
||||
'context': {
|
||||
'title':_(u'permissions'),
|
||||
'object_list':Permission.objects.all(),
|
||||
'extra_columns':[
|
||||
{'name':_(u'namespace'), 'attribute':'namespace'},
|
||||
{'name':_(u'name'), 'attribute':'label'},
|
||||
'title': _(u'permissions'),
|
||||
'object_list': Permission.objects.all(),
|
||||
'extra_columns': [
|
||||
{'name': _(u'namespace'), 'attribute': u'namespace'},
|
||||
{'name': _(u'name'), 'attribute': u'label'},
|
||||
{
|
||||
'name':_(u'state'),
|
||||
'attribute':lambda x: _role_permission_link(role, x, role_permissions_list),
|
||||
'attribute': lambda x: _role_permission_link(role, x, role_permissions_list),
|
||||
}
|
||||
],
|
||||
'hide_link':True,
|
||||
'hide_object':True,
|
||||
'hide_link': True,
|
||||
'hide_object': True,
|
||||
}
|
||||
},
|
||||
]
|
||||
@@ -117,6 +118,7 @@ def role_delete(request, role_id):
|
||||
'next': next,
|
||||
'previous': previous,
|
||||
'object_name': _(u'role'),
|
||||
'form_icon': u'medal_gold_delete.png',
|
||||
})
|
||||
|
||||
|
||||
@@ -143,7 +145,7 @@ def permission_grant_revoke(request, permission_id, app_label, module_name, pk,
|
||||
|
||||
if request.method == 'POST':
|
||||
if action == 'grant':
|
||||
permission_holder, created = PermissionHolder.objects.get_or_create(permission=permission, holder_type=ct, holder_id=requester.id)
|
||||
permission_holder, created = PermissionHolder.objects.get_or_create(permission=permission, holder_type=ct, holder_id=requester.pk)
|
||||
if created:
|
||||
messages.success(request, _(u'Permission "%(permission)s" granted to %(ct_name)s: %(requester)s.') % {
|
||||
'permission': permission, 'ct_name': ct.name, 'requester': requester})
|
||||
@@ -152,7 +154,7 @@ def permission_grant_revoke(request, permission_id, app_label, module_name, pk,
|
||||
'ct_name': ct.name, 'requester': requester, 'permission': permission})
|
||||
elif action == 'revoke':
|
||||
try:
|
||||
permission_holder = PermissionHolder.objects.get(permission=permission, holder_type=ct, holder_id=requester.id)
|
||||
permission_holder = PermissionHolder.objects.get(permission=permission, holder_type=ct, holder_id=requester.pk)
|
||||
permission_holder.delete()
|
||||
messages.success(request, _(u'Permission "%(permission)s" revoked from %(ct_name)s: %(requester)s.') % {
|
||||
'permission': permission, 'ct_name': ct.name, 'requester': requester})
|
||||
@@ -184,70 +186,33 @@ def get_non_role_members(role):
|
||||
return list(users | groups)
|
||||
|
||||
|
||||
def add_role_member(role, selection):
|
||||
model, pk = selection.split(u',')
|
||||
ct = ContentType.objects.get(model=model)
|
||||
new_member, created = RoleMember.objects.get_or_create(role=role, member_type=ct, member_id=pk)
|
||||
if not created:
|
||||
raise Exception
|
||||
|
||||
|
||||
def remove_role_member(role, selection):
|
||||
model, pk = selection.split(u',')
|
||||
ct = ContentType.objects.get(model=model)
|
||||
member = RoleMember.objects.get(role=role, member_type=ct, member_id=pk)
|
||||
member.delete()
|
||||
|
||||
|
||||
def role_members(request, role_id):
|
||||
check_permissions(request.user, 'permissions', [PERMISSION_ROLE_EDIT])
|
||||
role = get_object_or_404(Role, pk=role_id)
|
||||
|
||||
if request.method == 'POST':
|
||||
if 'unselected-users-submit' in request.POST.keys():
|
||||
unselected_users_form = ChoiceForm(request.POST,
|
||||
prefix='unselected-users',
|
||||
choices=generate_choices_w_labels(get_non_role_members(role)))
|
||||
if unselected_users_form.is_valid():
|
||||
for selection in unselected_users_form.cleaned_data['selection']:
|
||||
model, pk = selection.split(u',')
|
||||
ct = ContentType.objects.get(model=model)
|
||||
obj = ct.get_object_for_this_type(pk=pk)
|
||||
new_member, created = RoleMember.objects.get_or_create(role=role, member_type=ct, member_id=pk)
|
||||
if created:
|
||||
messages.success(request, _(u'%(obj)s added successfully to the role: %(role)s.') % {
|
||||
'obj': generate_choices_w_labels([obj])[0][1], 'role': role})
|
||||
|
||||
elif 'selected-users-submit' in request.POST.keys():
|
||||
selected_users_form = ChoiceForm(request.POST,
|
||||
prefix='selected-users',
|
||||
choices=generate_choices_w_labels(get_role_members(role)))
|
||||
if selected_users_form.is_valid():
|
||||
for selection in selected_users_form.cleaned_data['selection']:
|
||||
model, pk = selection.split(u',')
|
||||
ct = ContentType.objects.get(model=model)
|
||||
obj = ct.get_object_for_this_type(pk=pk)
|
||||
|
||||
try:
|
||||
member = RoleMember.objects.get(role=role, member_type=ct, member_id=pk)
|
||||
member.delete()
|
||||
messages.success(request, _(u'%(obj)s removed successfully from the role: %(role)s.') % {
|
||||
'obj': generate_choices_w_labels([obj])[0][1], 'role': role})
|
||||
except member.DoesNotExist:
|
||||
messages.error(request, _(u'Unable to remove %(obj)s from the role: %(role)s.') % {
|
||||
'obj': generate_choices_w_labels([obj])[0][1], 'role': role})
|
||||
|
||||
unselected_users_form = ChoiceForm(prefix='unselected-users',
|
||||
choices=generate_choices_w_labels(get_non_role_members(role)))
|
||||
selected_users_form = ChoiceForm(prefix='selected-users',
|
||||
choices=generate_choices_w_labels(get_role_members(role)))
|
||||
|
||||
context = {
|
||||
'object': role,
|
||||
'object_name': _(u'role'),
|
||||
'form_list': [
|
||||
{
|
||||
'form': unselected_users_form,
|
||||
'title': _(u'non members of role: %s') % role,
|
||||
'grid': 6,
|
||||
'grid_clear': False,
|
||||
'submit_label': _(u'Add'),
|
||||
},
|
||||
{
|
||||
'form': selected_users_form,
|
||||
'title': _(u'members of role: %s') % role,
|
||||
'grid': 6,
|
||||
'grid_clear': True,
|
||||
'submit_label': _(u'Remove'),
|
||||
},
|
||||
|
||||
],
|
||||
}
|
||||
|
||||
return render_to_response('generic_form.html', context,
|
||||
context_instance=RequestContext(request))
|
||||
return assign_remove(
|
||||
request,
|
||||
left_list=lambda: generate_choices_w_labels(get_non_role_members(role)),
|
||||
right_list=lambda: generate_choices_w_labels(get_role_members(role)),
|
||||
add_method=lambda x: add_role_member(role, x),
|
||||
remove_method=lambda x: remove_role_member(role, x),
|
||||
left_list_title=_(u'non members of role: %s') % role,
|
||||
right_list_title=_(u'members of role: %s') % role,
|
||||
obj=role,
|
||||
object_name=_(u'role'),
|
||||
)
|
||||
|
||||
Reference in New Issue
Block a user