Move add_to_class functions to their own module

* The new module is called methods.py and found on each app.
* Add keyword arguments to add_to_class instances.
* Remove catch all exception handling for the check in and
  check out views.
* Improve checkouts tests code reducing redundant code.

Signed-off-by: Roberto Rosario <roberto.rosario.gonzalez@gmail.com>

mayan/apps/ocr/apps.py

@@ -1,13 +1,11 @@
 from __future__ import unicode_literals
 
-from datetime import timedelta
 import logging
 
 from kombu import Exchange, Queue
 
 from django.apps import apps
 from django.db.models.signals import post_save
-from django.utils.timezone import now
 from django.utils.translation import ugettext_lazy as _
 
 from mayan.apps.acls import ModelPermission
@@ -16,14 +14,12 @@ from mayan.apps.common import (
     menu_tools
 )
 from mayan.apps.common.classes import ModelField
-from mayan.apps.common.settings import settings_db_sync_task_delay
 from mayan.apps.documents.search import document_search, document_page_search
 from mayan.apps.documents.signals import post_version_upload
 from mayan.apps.documents.widgets import document_link
 from mayan.apps.navigation import SourceColumn
 from mayan.celery import app
 
-from .events import event_ocr_document_version_submit
 from .handlers import (
     handler_index_document, handler_initialize_new_ocr_settings,
     handler_ocr_document_version,
@@ -35,6 +31,9 @@ from .links import (
     link_document_type_ocr_settings, link_document_type_submit,
     link_entry_list
 )
+from .methods import (
+    method_document_ocr_submit, method_document_version_ocr_submit
+)
 from .permissions import (
     permission_document_type_ocr_setup, permission_ocr_document,
     permission_ocr_content_view
@@ -46,26 +45,6 @@ from .utils import get_document_ocr_content
 logger = logging.getLogger(__name__)
 
 
-def document_ocr_submit(self):
-    latest_version = self.latest_version
-    # Don't error out if document has no version
-    if latest_version:
-        latest_version.submit_for_ocr()
-
-
-def document_version_ocr_submit(self):
-    from .tasks import task_do_ocr
-
-    event_ocr_document_version_submit.commit(
-        action_object=self.document, target=self
-    )
-
-    task_do_ocr.apply_async(
-        eta=now() + timedelta(seconds=settings_db_sync_task_delay.value),
-        kwargs={'document_version_pk': self.pk},
-    )
-
-
 class OCRApp(MayanAppConfig):
     app_namespace = 'ocr'
     app_url = 'ocr'
@@ -95,12 +74,14 @@ class OCRApp(MayanAppConfig):
 
         DocumentVersionOCRError = self.get_model('DocumentVersionOCRError')
 
-        Document.add_to_class('submit_for_ocr', document_ocr_submit)
-        DocumentVersion.add_to_class(
-            'ocr_content', get_document_ocr_content
+        Document.add_to_class(
+            name='submit_for_ocr', value=method_document_ocr_submit
         )
         DocumentVersion.add_to_class(
-            'submit_for_ocr', document_version_ocr_submit
+            name='ocr_content', value=get_document_ocr_content
+        )
+        DocumentVersion.add_to_class(
+            name='submit_for_ocr', value=method_document_version_ocr_submit
         )
 
         ModelField(