matthias/mayan-edms
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix role creation API not returning id of new role. GitLab issue #390.

Browse Source 
Thanks to @lokeshmanmode for the find.

Signed-off-by: Roberto Rosario <roberto.rosario.gonzalez@gmail.com>
This commit is contained in:
Roberto Rosario
2017-06-17 03:00:58 -04:00
parent 215b76bfab
commit 40ab6b6f9f
3 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
HISTORY.rst
View File

@@ -5,6 +5,7 @@ XX (2017-XX-XX)
- Add SANE scanner document source. - Add SANE scanner document source.
- Added PDF orientation detection. GitLab issue #387. - Added PDF orientation detection. GitLab issue #387.
- Fix repeated permission list API URL. GitLab issue #389. - Fix repeated permission list API URL. GitLab issue #389.
- Fix role creation API endpoint not returning id. GitLab issue #390.
2.3 (2017-06-08) 2.3 (2017-06-08)
================ ================

2
mayan/apps/permissions/serializers.py
View File

@@ -75,7 +75,7 @@ class WritableRoleSerializer(serializers.HyperlinkedModelSerializer):
if self.permissions_pk_list: if self.permissions_pk_list:
self._add_permissions(instance=instance) self._add_permissions(instance=instance)
return result return instance
def _add_groups(self, instance): def _add_groups(self, instance):
instance.groups.add( instance.groups.add(

5
mayan/apps/permissions/tests/test_api.py
View File

@@ -59,9 +59,12 @@ class PermissionAPITestCase(BaseAPITestCase):
def test_role_create_view(self): def test_role_create_view(self):
response = self._role_create_request() response = self._role_create_request()
role = Role.objects.first()
self.assertEqual(response.status_code, 201) self.assertEqual(response.status_code, 201)
self.assertEqual(response.data, {'label': role.label, 'id': role.pk})
self.assertEqual(Role.objects.count(), 1) self.assertEqual(Role.objects.count(), 1)
self.assertEqual(Role.objects.first().label, TEST_ROLE_LABEL) self.assertEqual(role.label, TEST_ROLE_LABEL)
def _create_group(self): def _create_group(self):
self.group = Group.objects.create(name=TEST_GROUP_NAME) self.group = Group.objects.create(name=TEST_GROUP_NAME)