From 2f67f0cffa92891b99d0d1610119e82a34cefc11 Mon Sep 17 00:00:00 2001
From: Roberto Rosario <roberto.rosario.gonzalez@gmail.com>
Date: Sat, 28 Jan 2017 18:15:25 -0400
Subject: [PATCH] Improve document version comment API tests. Add document
 description update API tests. GitLab issues #348 and #349.

---
 mayan/apps/documents/tests/literals.py |  1 +
 mayan/apps/documents/tests/test_api.py | 54 +++++++++++++++++++++-----
 2 files changed, 45 insertions(+), 10 deletions(-)

diff --git a/mayan/apps/documents/tests/literals.py b/mayan/apps/documents/tests/literals.py
index b2eceadfc5..289b67d526 100644
--- a/mayan/apps/documents/tests/literals.py
+++ b/mayan/apps/documents/tests/literals.py
@@ -23,6 +23,7 @@ __all__ = (
 TEST_COMPRESSED_DOCUMENTS_FILENAME = 'compressed_documents.zip'
 TEST_DEU_DOCUMENT_FILENAME = 'deu_website.png'
 TEST_DOCUMENT_DESCRIPTION = 'test description'
+TEST_DOCUMENT_DESCRIPTION_EDITED = 'test document description edited'
 TEST_DOCUMENT_FILENAME = 'mayan_11_1.pdf'
 TEST_DOCUMENT_TYPE = 'test_document_type'
 TEST_DOCUMENT_TYPE_2 = 'test document type 2'
diff --git a/mayan/apps/documents/tests/test_api.py b/mayan/apps/documents/tests/test_api.py
index afc33471d6..7195b01b15 100644
--- a/mayan/apps/documents/tests/test_api.py
+++ b/mayan/apps/documents/tests/test_api.py
@@ -20,9 +20,9 @@ from user_management.tests.literals import (
 )
 
 from .literals import (
-    TEST_DOCUMENT_FILENAME, TEST_DOCUMENT_PATH, TEST_DOCUMENT_TYPE,
-    TEST_SMALL_DOCUMENT_CHECKSUM, TEST_SMALL_DOCUMENT_PATH,
-    TEST_DOCUMENT_VERSION_COMMENT_EDITED
+    TEST_DOCUMENT_FILENAME, TEST_DOCUMENT_DESCRIPTION_EDITED,
+    TEST_DOCUMENT_PATH, TEST_DOCUMENT_TYPE, TEST_SMALL_DOCUMENT_CHECKSUM,
+    TEST_SMALL_DOCUMENT_PATH, TEST_DOCUMENT_VERSION_COMMENT_EDITED
 )
 from ..models import Document, DocumentType, HASH_FUNCTION
 
@@ -300,18 +300,15 @@ class DocumentAPITestCase(APITestCase):
 
         del(buf)
 
-    def _edit_document_version(self):
-        return self.client.patch(
+    def test_document_version_edit_via_patch(self):
+        self._upload_document()
+        response = self.client.patch(
             reverse(
                 'rest_api:documentversion-detail',
                 args=(self.document.latest_version.pk,)
             ), data={'comment': TEST_DOCUMENT_VERSION_COMMENT_EDITED}
         )
 
-    def test_document_version_edit_via_patch(self):
-        self._upload_document()
-        response = self._edit_document_version()
-
         self.assertEqual(response.status_code, 200)
         self.document.latest_version.refresh_from_db()
         self.assertEqual(self.document.versions.count(), 1)
@@ -322,7 +319,12 @@ class DocumentAPITestCase(APITestCase):
 
     def test_document_version_edit_via_put(self):
         self._upload_document()
-        response = self._edit_document_version()
+        response = self.client.put(
+            reverse(
+                'rest_api:documentversion-detail',
+                args=(self.document.latest_version.pk,)
+            ), data={'comment': TEST_DOCUMENT_VERSION_COMMENT_EDITED}
+        )
 
         self.assertEqual(response.status_code, 200)
         self.document.latest_version.refresh_from_db()
@@ -332,5 +334,37 @@ class DocumentAPITestCase(APITestCase):
             TEST_DOCUMENT_VERSION_COMMENT_EDITED
         )
 
+    def test_document_comment_edit_via_patch(self):
+        self._upload_document()
+        response = self.client.patch(
+            reverse(
+                'rest_api:document-detail',
+                args=(self.document.pk,)
+            ), data={'description': TEST_DOCUMENT_DESCRIPTION_EDITED}
+        )
+
+        self.assertEqual(response.status_code, 200)
+        self.document.refresh_from_db()
+        self.assertEqual(
+            self.document.description,
+            TEST_DOCUMENT_DESCRIPTION_EDITED
+        )
+
+    def test_document_comment_edit_via_put(self):
+        self._upload_document()
+        response = self.client.put(
+            reverse(
+                'rest_api:document-detail',
+                args=(self.document.pk,)
+            ), data={'description': TEST_DOCUMENT_DESCRIPTION_EDITED}
+        )
+
+        self.assertEqual(response.status_code, 200)
+        self.document.refresh_from_db()
+        self.assertEqual(
+            self.document.description,
+            TEST_DOCUMENT_DESCRIPTION_EDITED
+        )
+
     # TODO: def test_document_set_document_type(self):
     #    pass