matthias/mayan-edms
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Update linking app

Browse Source 
Add keyword arguments. Update URL parameters to the '_id' form.
Movernize tests and update them to use the latest test case
improvements.

Signed-off-by: Roberto Rosario <Roberto.Rosario@mayan-edms.com>
This commit is contained in:
Roberto Rosario
2019-01-21 02:00:22 -04:00
parent c0b34067ef
commit 2e5d05403a
10 changed files with 233 additions and 216 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
mayan/apps/linking/tests/mixins.py Normal file
View File

@@ -0,0 +1,13 @@
from __future__ import unicode_literals
from ..models import SmartLink
from .literals import TEST_SMART_LINK_DYNAMIC_LABEL, TEST_SMART_LINK_LABEL
class SmartLinkTestMixin(object):
def _create_test_smart_link(self):
self.test_smart_link = SmartLink.objects.create(
label=TEST_SMART_LINK_LABEL,
dynamic_label=TEST_SMART_LINK_DYNAMIC_LABEL
)

10
mayan/apps/linking/tests/test_api.py
View File

@@ -66,7 +66,7 @@ class SmartLinkAPITestCase(DocumentTestMixin, BaseAPITestCase):
return self.post(
viewname='rest_api:smartlink-list', data={
'label': TEST_SMART_LINK_LABEL,
'document_types_pk_list': self.document_type.pk
'document_types_id_list': self.document_type.pk
},
)
@@ -135,7 +135,7 @@ class SmartLinkAPITestCase(DocumentTestMixin, BaseAPITestCase):
viewname='rest_api:smartlink-detail',
args=(self.smart_link.pk,), data={
'label': TEST_SMART_LINK_LABEL_EDITED,
'document_types_pk_list': self.document_type.pk
'document_types_id_list': self.document_type.pk
}
)
@@ -163,7 +163,7 @@ class SmartLinkAPITestCase(DocumentTestMixin, BaseAPITestCase):
viewname='rest_api:smartlink-detail',
args=(self.smart_link.pk,), data={
'label': TEST_SMART_LINK_LABEL_EDITED,
'document_types_pk_list': self.document_type.pk
'document_types_id_list': self.document_type.pk
}
)
@@ -253,7 +253,9 @@ class SmartLinkConditionAPITestCase(BaseAPITestCase):
self._create_smart_link()
self._create_smart_link_condition()
self._create_document()
self.grant_access(permission=permission_smart_link_view, obj=self.smart_link)
self.grant_access(
obj=self.smart_link, permission=permission_smart_link_view
)
response = self._request_resolved_smart_link_detail_view()
self.assertEqual(response.status_code, status.HTTP_403_FORBIDDEN)
self.assertFalse('label' in response.data)

16
mayan/apps/linking/tests/test_models.py
View File

@@ -2,20 +2,16 @@ from __future__ import unicode_literals
from mayan.apps.documents.tests import GenericDocumentTestCase
from ..models import SmartLink
from .literals import TEST_SMART_LINK_DYNAMIC_LABEL, TEST_SMART_LINK_LABEL
from .mixins import SmartLinkTestMixin
class SmartLinkTestCase(GenericDocumentTestCase):
class SmartLinkTestCase(SmartLinkTestMixin, GenericDocumentTestCase):
def test_dynamic_label(self):
smart_link = SmartLink.objects.create(
label=TEST_SMART_LINK_LABEL,
dynamic_label=TEST_SMART_LINK_DYNAMIC_LABEL
)
smart_link.document_types.add(self.document_type)
self._create_test_smart_link()
self.test_smart_link.document_types.add(self.document_type)
self.assertEqual(
smart_link.get_dynamic_label(document=self.document),
self.test_smart_link.get_dynamic_label(document=self.document),
self.document.label
)

156
mayan/apps/linking/tests/test_views.py
View File

@@ -14,121 +14,116 @@ from .literals import (
TEST_SMART_LINK_DYNAMIC_LABEL, TEST_SMART_LINK_LABEL,
TEST_SMART_LINK_LABEL_EDITED
)
from .mixins import SmartLinkTestMixin
class SmartLinkViewTestCase(GenericViewTestCase):
def setUp(self):
super(SmartLinkViewTestCase, self).setUp()
self.login_user()
def test_smart_link_create_view_no_permission(self):
response = self.post(
'linking:smart_link_create', data={
class SmartLinkViewTestCase(SmartLinkTestMixin, GenericViewTestCase):
def _request_smart_link_create_view(self):
return self.post(
viewname='linking:smart_link_create', data={
'label': TEST_SMART_LINK_LABEL
}
)
self.assertEquals(response.status_code, 403)
def test_smart_link_create_view_no_permission(self):
response = self._request_smart_link_create_view()
self.assertEqual(response.status_code, 403)
self.assertEqual(SmartLink.objects.count(), 0)
def test_smart_link_create_view_with_permission(self):
self.role.permissions.add(
permission_smart_link_create.stored_permission
)
self.grant_permission(permission=permission_smart_link_create)
response = self._request_smart_link_create_view()
self.assertEqual(response.status_code, 302)
response = self.post(
'linking:smart_link_create', data={
'label': TEST_SMART_LINK_LABEL
}, follow=True
)
self.assertContains(response, text='created', status_code=200)
self.assertEqual(SmartLink.objects.count(), 1)
self.assertEqual(
SmartLink.objects.first().label, TEST_SMART_LINK_LABEL
)
def test_smart_link_delete_view_no_permission(self):
smart_link = SmartLink.objects.create(label=TEST_SMART_LINK_LABEL)
response = self.post(
'linking:smart_link_delete', args=(smart_link.pk,)
def _request_smart_link_delete_view(self):
return self.post(
viewname='linking:smart_link_delete',
kwargs={'smart_link_id': self.test_smart_link.pk}
)
self.assertEqual(response.status_code, 403)
def test_smart_link_delete_view_no_permission(self):
self._create_test_smart_link()
response = self._request_smart_link_delete_view()
self.assertEqual(response.status_code, 404)
self.assertEqual(SmartLink.objects.count(), 1)
def test_smart_link_delete_view_with_permission(self):
self.role.permissions.add(
permission_smart_link_delete.stored_permission
def test_smart_link_delete_view_with_access(self):
self._create_test_smart_link()
self.grant_access(
obj=self.test_smart_link, permission=permission_smart_link_delete
)
response = self._request_smart_link_delete_view()
self.assertEqual(response.status_code, 302)
smart_link = SmartLink.objects.create(label=TEST_SMART_LINK_LABEL)
response = self.post(
'linking:smart_link_delete', args=(smart_link.pk,), follow=True
)
self.assertContains(response, text='deleted', status_code=200)
self.assertEqual(SmartLink.objects.count(), 0)
def test_smart_link_edit_view_no_permission(self):
smart_link = SmartLink.objects.create(label=TEST_SMART_LINK_LABEL)
response = self.post(
'linking:smart_link_edit', args=(smart_link.pk,), data={
def _request_smart_link_edit_view(self):
return self.post(
viewname='linking:smart_link_edit',
kwargs={'smart_link_id': self.test_smart_link.pk}, data={
'label': TEST_SMART_LINK_LABEL_EDITED
}
)
self.assertEqual(response.status_code, 403)
smart_link = SmartLink.objects.get(pk=smart_link.pk)
self.assertEqual(smart_link.label, TEST_SMART_LINK_LABEL)
def test_smart_link_edit_view_with_permission(self):
self.role.permissions.add(
permission_smart_link_edit.stored_permission
def test_smart_link_edit_view_no_permission(self):
self._create_test_smart_link()
response = self._request_smart_link_edit_view()
self.assertEqual(response.status_code, 404)
self.test_smart_link.refresh_from_db()
self.assertEqual(self.test_smart_link.label, TEST_SMART_LINK_LABEL)
def test_smart_link_edit_view_with_access(self):
self._create_test_smart_link()
self.grant_access(
obj=self.test_smart_link, permission=permission_smart_link_edit
)
response = self._request_smart_link_edit_view()
self.assertEqual(response.status_code, 302)
smart_link = SmartLink.objects.create(label=TEST_SMART_LINK_LABEL)
response = self.post(
'linking:smart_link_edit', args=(smart_link.pk,), data={
'label': TEST_SMART_LINK_LABEL_EDITED
}, follow=True
self.test_smart_link.refresh_from_db()
self.assertEqual(
self.test_smart_link.label, TEST_SMART_LINK_LABEL_EDITED
)
smart_link = SmartLink.objects.get(pk=smart_link.pk)
self.assertContains(response, text='update', status_code=200)
self.assertEqual(smart_link.label, TEST_SMART_LINK_LABEL_EDITED)
class SmartLinkDocumentsViewTestCase(GenericDocumentViewTestCase):
def setUp(self):
super(SmartLinkDocumentsViewTestCase, self).setUp()
self.login_user()
def setup_smart_links(self):
smart_link = SmartLink.objects.create(
def _setup_smart_links(self):
self.test_smart_link = SmartLink.objects.create(
label=TEST_SMART_LINK_LABEL,
dynamic_label=TEST_SMART_LINK_DYNAMIC_LABEL
)
smart_link.document_types.add(self.document_type)
self.test_smart_link.document_types.add(self.document_type)
smart_link_2 = SmartLink.objects.create(
self.test_smart_link_2 = SmartLink.objects.create(
label=TEST_SMART_LINK_LABEL,
dynamic_label=TEST_SMART_LINK_DYNAMIC_LABEL
)
smart_link_2.document_types.add(self.document_type)
self.test_smart_link_2.document_types.add(self.document_type)
def _request_document_resolved_smart_links_for_document_view(self):
return self.get(
viewname='linking:resolved_smart_links_for_document',
kwargs={'document_id': self.document.pk}
)
def test_document_smart_link_list_view_no_permission(self):
self.setup_smart_links()
self._setup_smart_links()
self.role.permissions.add(
permission_document_view.stored_permission
)
self.grant_access(obj=self.document, permission=permission_document_view)
response = self.get(
'linking:smart_link_instances_for_document',
args=(self.document.pk,)
)
response = self._request_document_resolved_smart_links_for_document_view()
# Text must appear 3 times, 2 for the window titles and template
# heading. The two smart links are not shown.
@@ -137,20 +132,13 @@ class SmartLinkDocumentsViewTestCase(GenericDocumentViewTestCase):
)
def test_document_smart_link_list_view_with_permission(self):
self.setup_smart_links()
self._setup_smart_links()
self.role.permissions.add(
permission_smart_link_view.stored_permission
)
self.role.permissions.add(
permission_document_view.stored_permission
)
response = self.get(
'linking:smart_link_instances_for_document',
args=(self.document.pk,)
self.grant_access(obj=self.document, permission=permission_document_view)
self.grant_access(
obj=self.test_smart_link, permission=permission_smart_link_view
)
response = self._request_document_resolved_smart_links_for_document_view()
# Text must appear 5 times: 3 for the window titles and template
# heading, plus 2 for the test.