From 2e231dad62b6187d663a185a8ae7524333d1e924 Mon Sep 17 00:00:00 2001 From: Roberto Rosario Date: Tue, 12 Nov 2019 13:54:43 -0400 Subject: [PATCH] Organize smart settings view tests Signed-off-by: Roberto Rosario --- mayan/apps/smart_settings/tests/mixins.py | 12 ++++++++++++ mayan/apps/smart_settings/tests/test_views.py | 16 ++++------------ 2 files changed, 16 insertions(+), 12 deletions(-) diff --git a/mayan/apps/smart_settings/tests/mixins.py b/mayan/apps/smart_settings/tests/mixins.py index 2991121903..aa177930dc 100644 --- a/mayan/apps/smart_settings/tests/mixins.py +++ b/mayan/apps/smart_settings/tests/mixins.py @@ -21,3 +21,15 @@ class SmartSettingTestMixin(object): self.test_settings_namespace = Namespace( label=TEST_NAMESPACE_LABEL, name=TEST_NAMESPACE_NAME ) + + +class SmartSettingViewTestMixin(object): + def _request_namespace_list_view(self): + return self.get(viewname='settings:namespace_list') + + def _request_namespace_detail_view(self): + return self.get( + viewname='settings:namespace_detail', kwargs={ + 'namespace_name': self.test_settings_namespace.name + } + ) diff --git a/mayan/apps/smart_settings/tests/test_views.py b/mayan/apps/smart_settings/tests/test_views.py index 78e972e069..7377e853b2 100644 --- a/mayan/apps/smart_settings/tests/test_views.py +++ b/mayan/apps/smart_settings/tests/test_views.py @@ -4,24 +4,16 @@ from mayan.apps.common.tests.base import GenericViewTestCase from ..permissions import permission_settings_view -from .mixins import SmartSettingTestMixin +from .mixins import SmartSettingTestMixin, SmartSettingViewTestMixin -class SmartSettingViewTestCase(SmartSettingTestMixin, GenericViewTestCase): +class SmartSettingViewTestCase( + SmartSettingTestMixin, SmartSettingViewTestMixin, GenericViewTestCase +): def setUp(self): super(SmartSettingViewTestCase, self).setUp() self._create_test_settings_namespace() - def _request_namespace_list_view(self): - return self.get(viewname='settings:namespace_list') - - def _request_namespace_detail_view(self): - return self.get( - viewname='settings:namespace_detail', kwargs={ - 'namespace_name': self.test_settings_namespace.name - } - ) - def test_namespace_list_view_no_permission(self): response = self._request_namespace_list_view() self.assertEqual(response.status_code, 403)