From 1034a3056d38d151e8d918825d1e27faf2f4f0ab Mon Sep 17 00:00:00 2001 From: Roberto Rosario Date: Wed, 8 Aug 2018 01:15:30 -0400 Subject: [PATCH] Display error when attempting to recalculate the page count of an empty document (document stub that has no document version). Signed-off-by: Roberto Rosario --- HISTORY.rst | 2 ++ mayan/apps/documents/views/document_views.py | 18 +++++++++++++++--- 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/HISTORY.rst b/HISTORY.rst index 928d2ae77b..b2934bf936 100644 --- a/HISTORY.rst +++ b/HISTORY.rst @@ -21,6 +21,8 @@ - Update dropzone.js' timeout from 30 seconds to 120 to allow upload of large files on slow connections. - Increase gunicorn's timeout from 30 seconds to 120. +- Display error when attempting to recalculate the page count of an empty + document (document stub that has no document version). 3.0.1 (2018-07-08) ================= diff --git a/mayan/apps/documents/views/document_views.py b/mayan/apps/documents/views/document_views.py index 60313eb94d..f2e7e6cbc9 100644 --- a/mayan/apps/documents/views/document_views.py +++ b/mayan/apps/documents/views/document_views.py @@ -596,9 +596,21 @@ class DocumentUpdatePageCountView(MultipleObjectConfirmActionView): return result def object_action(self, form, instance): - task_update_page_count.apply_async( - kwargs={'version_id': instance.latest_version.pk} - ) + latest_version = instance.latest_version + if latest_version: + task_update_page_count.apply_async( + kwargs={'version_id': latest_version.pk} + ) + else: + messages.error( + self.request, _( + 'Document "%(document)s" is empty. Upload at least one ' + 'document version before attempting to detect the ' + 'page count.' + ) % { + 'document': instance, + } + ) class DocumentTransformationsClearView(MultipleObjectConfirmActionView):