From 07c595fd65e4b636170cdb2e60d026f5c94c1615 Mon Sep 17 00:00:00 2001 From: Roberto Rosario Date: Thu, 23 Oct 2014 03:17:25 -0400 Subject: [PATCH] Reuse expensive values to improve issue #49 --- mayan/apps/documents/widgets.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/mayan/apps/documents/widgets.py b/mayan/apps/documents/widgets.py index 63347415a4..35388fa65e 100644 --- a/mayan/apps/documents/widgets.py +++ b/mayan/apps/documents/widgets.py @@ -43,6 +43,10 @@ class DocumentPagesCarouselWidget(forms.widgets.Widget): except AttributeError: document_pages = [] + # Reuse expensive values + latest_version_pk = value.latest_version.pk + page_count = value.page_count + for page in document_pages: output.append(u'
') output.append(u'
%(page_string)s %(page)s
' % {'page_string': ugettext(u'Page'), 'page': page.page_number}) @@ -54,8 +58,9 @@ class DocumentPagesCarouselWidget(forms.widgets.Widget): gallery_name='document_pages', fancybox_class='fancybox-noscaling', image_class='lazy-load-carousel', - title=ugettext(u'Page %(page_num)d of %(total_pages)d') % {'page_num': page.page_number, 'total_pages': value.page_count}, + title=ugettext(u'Page %(page_num)d of %(total_pages)d') % {'page_num': page.page_number, 'total_pages': page_count}, size=MULTIPAGE_PREVIEW_SIZE, + version=latest_version_pk ) ) output.append(u'
')