matthias/mayan-edms
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Backport test improvements

Browse Source 
Signed-off-by: Roberto Rosario <roberto.rosario.gonzalez@gmail.com>
This commit is contained in:
Roberto Rosario
2019-04-20 02:39:57 -04:00
parent bfcad278aa
commit 0267c79b07
108 changed files with 5434 additions and 4685 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
mayan/apps/document_indexing/tests/mixins.py
View File

@@ -6,9 +6,13 @@ from .literals import TEST_INDEX_LABEL
class DocumentIndexingTestMixin(object):
def _create_index(self):
def _create_test_index(self, rebuild=False):
# Create empty index
self.index = Index.objects.create(label=TEST_INDEX_LABEL)
self.test_index = Index.objects.create(label=TEST_INDEX_LABEL)
# Add our document type to the new index
self.index.document_types.add(self.document_type)
self.test_index.document_types.add(self.test_document_type)
# Rebuild indexes
if rebuild:
Index.objects.rebuild()

26
mayan/apps/document_indexing/tests/test_api.py
View File

@@ -18,10 +18,6 @@ from .mixins import DocumentIndexingTestMixin
class DocumentIndexingAPITestCase(DocumentIndexingTestMixin, DocumentTestMixin, BaseAPITestCase):
auto_upload_document = False
def setUp(self):
super(DocumentIndexingAPITestCase, self).setUp()
self.login_user()
def _request_index_create_api_view(self):
return self.post(
viewname='rest_api:index-list', data={
@@ -53,39 +49,39 @@ class DocumentIndexingAPITestCase(DocumentIndexingTestMixin, DocumentTestMixin,
def _request_index_delete_api_view(self):
return self.delete(
viewname='rest_api:index-detail', kwargs={
'pk': self.index.pk
'pk': self.test_index.pk
}
)
def test_index_delete_api_view_no_permission(self):
self._create_index()
self._create_test_index()
response = self._request_index_delete_api_view()
self.assertEqual(response.status_code, status.HTTP_403_FORBIDDEN)
self.assertTrue(self.index in Index.objects.all())
self.assertTrue(self.test_index in Index.objects.all())
def test_index_delete_api_view_with_access(self):
self._create_index()
self._create_test_index()
self.grant_access(
obj=self.index, permission=permission_document_indexing_delete
obj=self.test_index, permission=permission_document_indexing_delete
)
response = self._request_index_delete_api_view()
self.assertEqual(response.status_code, status.HTTP_204_NO_CONTENT)
self.assertTrue(self.index not in Index.objects.all())
self.assertTrue(self.test_index not in Index.objects.all())
def _request_index_detail_api_view(self):
return self.get(
viewname='rest_api:index-detail', kwargs={
'pk': self.index.pk
'pk': self.test_index.pk
}
)
def test_index_detail_api_view_no_access(self):
self._create_index()
self._create_test_index()
response = self._request_index_detail_api_view()
@@ -93,15 +89,15 @@ class DocumentIndexingAPITestCase(DocumentIndexingTestMixin, DocumentTestMixin,
self.assertTrue('id' not in response.data)
def test_index_detail_api_view_with_access(self):
self._create_index()
self._create_test_index()
self.grant_access(
obj=self.index, permission=permission_document_indexing_view
obj=self.test_index, permission=permission_document_indexing_view
)
response = self._request_index_detail_api_view()
self.assertEqual(response.status_code, status.HTTP_200_OK)
self.assertEqual(
response.data['id'], self.index.pk
response.data['id'], self.test_index.pk
)

54
mayan/apps/document_indexing/tests/test_models.py
View File

@@ -1,6 +1,5 @@
from __future__ import unicode_literals
from django.test import override_settings
from django.utils.encoding import force_text
from mayan.apps.common.tests import BaseTestCase
@@ -24,13 +23,12 @@ from .literals import (
from .mixins import DocumentIndexingTestMixin
@override_settings(OCR_AUTO_OCR=False)
class IndexTestCase(DocumentIndexingTestMixin, DocumentTestMixin, BaseTestCase):
def test_document_description_index(self):
self._create_index()
self._create_test_index()
self.index.node_templates.create(
parent=self.index.template_root,
self.test_index.node_templates.create(
parent=self.test_index.template_root,
expression=TEST_INDEX_TEMPLATE_DOCUMENT_DESCRIPTION_EXPRESSION,
link_documents=True
)
@@ -38,7 +36,7 @@ class IndexTestCase(DocumentIndexingTestMixin, DocumentTestMixin, BaseTestCase):
self.document.description = TEST_DOCUMENT_DESCRIPTION
self.document.save()
self.index.rebuild()
self.test_index.rebuild()
self.assertEqual(
IndexInstanceNode.objects.last().value, self.document.description
@@ -51,15 +49,15 @@ class IndexTestCase(DocumentIndexingTestMixin, DocumentTestMixin, BaseTestCase):
)
def test_document_label_index(self):
self._create_index()
self._create_test_index()
self.index.node_templates.create(
parent=self.index.template_root,
self.test_index.node_templates.create(
parent=self.test_index.template_root,
expression=TEST_INDEX_TEMPLATE_DOCUMENT_LABEL_EXPRESSION,
link_documents=True
)
self.index.rebuild()
self.test_index.rebuild()
self.assertEqual(
IndexInstanceNode.objects.last().value, self.document.label
@@ -72,15 +70,15 @@ class IndexTestCase(DocumentIndexingTestMixin, DocumentTestMixin, BaseTestCase):
)
def test_date_based_index(self):
self._create_index()
self._create_test_index()
level_year = self.index.node_templates.create(
parent=self.index.template_root,
level_year = self.test_index.node_templates.create(
parent=self.test_index.template_root,
expression='{{ document.date_added|date:"Y" }}',
link_documents=False
)
self.index.node_templates.create(
self.test_index.node_templates.create(
parent=level_year,
expression='{{ document.date_added|date:"m" }}',
link_documents=True
@@ -116,16 +114,16 @@ class IndexTestCase(DocumentIndexingTestMixin, DocumentTestMixin, BaseTestCase):
file_object=file_object
)
self._create_index()
self._create_test_index()
# Create simple index template
root = self.index.template_root
level_1 = self.index.node_templates.create(
root = self.test_index.template_root
level_1 = self.test_index.node_templates.create(
parent=root, expression='{{ document.uuid }}',
link_documents=False
)
self.index.node_templates.create(
self.test_index.node_templates.create(
parent=level_1, expression='{{ document.label }}',
link_documents=True
)
@@ -151,11 +149,11 @@ class IndexTestCase(DocumentIndexingTestMixin, DocumentTestMixin, BaseTestCase):
document_type=self.document_type, metadata_type=metadata_type
)
self._create_index()
self._create_test_index()
# Create simple index template
root = self.index.template_root
self.index.node_templates.create(
root = self.test_index.template_root
self.test_index.node_templates.create(
parent=root, expression=TEST_INDEX_TEMPLATE_METADATA_EXPRESSION,
link_documents=True
)
@@ -236,15 +234,15 @@ class IndexTestCase(DocumentIndexingTestMixin, DocumentTestMixin, BaseTestCase):
On a two level template if the first level doesn't return a result
the indexing should stop. GitLab issue #391.
"""
self._create_index()
self._create_test_index()
level_1 = self.index.node_templates.create(
parent=self.index.template_root,
level_1 = self.test_index.node_templates.create(
parent=self.test_index.template_root,
expression='',
link_documents=True
)
self.index.node_templates.create(
self.test_index.node_templates.create(
parent=level_1, expression='{{ document.label }}',
link_documents=True
)
@@ -263,11 +261,11 @@ class IndexTestCase(DocumentIndexingTestMixin, DocumentTestMixin, BaseTestCase):
metadata_type=metadata_type, value='0001'
)
self._create_index()
self._create_test_index()
# Create simple index template
root = self.index.template_root
self.index.node_templates.create(
root = self.test_index.template_root
self.test_index.node_templates.create(
parent=root, expression='{{ document.metadata_value_of.test }}',
link_documents=True
)

130
mayan/apps/document_indexing/tests/test_views.py
View File

@@ -11,19 +11,15 @@ from ..permissions import (
)
from .literals import (
TEST_INDEX_LABEL, TEST_INDEX_LABEL_EDITED, TEST_INDEX_SLUG,
TEST_INDEX_TEMPLATE_DOCUMENT_LABEL_EXPRESSION
TEST_INDEX_LABEL, TEST_INDEX_LABEL_EDITED, TEST_INDEX_SLUG
)
from .mixins import DocumentIndexingTestMixin
class IndexViewTestCase(GenericDocumentViewTestCase):
def setUp(self):
super(IndexViewTestCase, self).setUp()
self.login_user()
class IndexViewTestCase(DocumentIndexingTestMixin, GenericDocumentViewTestCase):
def _request_index_create_view(self):
return self.post(
'indexing:index_setup_create', data={
viewname='indexing:index_setup_create', data={
'label': TEST_INDEX_LABEL, 'slug': TEST_INDEX_SLUG
}
)
@@ -31,6 +27,7 @@ class IndexViewTestCase(GenericDocumentViewTestCase):
def test_index_create_view_no_permission(self):
response = self._request_index_create_view()
self.assertEquals(response.status_code, 403)
self.assertEqual(Index.objects.count(), 0)
def test_index_create_view_with_permission(self):
@@ -39,113 +36,93 @@ class IndexViewTestCase(GenericDocumentViewTestCase):
)
response = self._request_index_create_view()
self.assertEqual(response.status_code, 302)
self.assertEqual(Index.objects.count(), 1)
self.assertEqual(Index.objects.first().label, TEST_INDEX_LABEL)
def _request_index_delete_view(self, index):
return self.post('indexing:index_setup_delete', args=(index.pk,))
def test_index_delete_view_no_permission(self):
index = Index.objects.create(
label=TEST_INDEX_LABEL, slug=TEST_INDEX_SLUG
def _request_index_delete_view(self):
return self.post(
viewname='indexing:index_setup_delete', kwargs={
'pk': self.test_index.pk
}
)
response = self._request_index_delete_view(index=index)
def test_index_delete_view_no_permission(self):
self._create_test_index()
response = self._request_index_delete_view()
self.assertEqual(response.status_code, 403)
self.assertEqual(Index.objects.count(), 1)
def test_index_delete_view_with_permission(self):
self.role.permissions.add(
permission_document_indexing_delete.stored_permission
)
self._create_test_index()
index = Index.objects.create(
label=TEST_INDEX_LABEL, slug=TEST_INDEX_SLUG
)
response = self._request_index_delete_view(index=index)
self.grant_permission(permission=permission_document_indexing_delete)
response = self._request_index_delete_view()
self.assertEqual(response.status_code, 302)
self.assertEqual(Index.objects.count(), 0)
def _request_index_edit_view(self, index):
def _request_index_edit_view(self):
return self.post(
'indexing:index_setup_edit', args=(index.pk,), data={
viewname='indexing:index_setup_edit', kwargs={
'pk': self.test_index.pk
}, data={
'label': TEST_INDEX_LABEL_EDITED, 'slug': TEST_INDEX_SLUG
}
)
def test_index_edit_view_no_permission(self):
index = Index.objects.create(
label=TEST_INDEX_LABEL, slug=TEST_INDEX_SLUG
)
self._create_test_index()
response = self._request_index_edit_view(index=index)
response = self._request_index_edit_view()
self.assertEqual(response.status_code, 403)
index = Index.objects.get(pk=index.pk)
self.assertEqual(index.label, TEST_INDEX_LABEL)
self.test_index.refresh_from_db()
self.assertEqual(self.test_index.label, TEST_INDEX_LABEL)
def test_index_edit_view_with_access(self):
index = Index.objects.create(
label=TEST_INDEX_LABEL, slug=TEST_INDEX_SLUG
)
self._create_test_index()
self.grant_access(
permission=permission_document_indexing_edit,
obj=index
obj=self.test_index, permission=permission_document_indexing_edit
)
response = self._request_index_edit_view(index=index)
response = self._request_index_edit_view()
self.assertEqual(response.status_code, 302)
index.refresh_from_db()
self.assertEqual(index.label, TEST_INDEX_LABEL_EDITED)
def _create_index(self, rebuild=True):
# Create empty index
self.index = Index.objects.create(label=TEST_INDEX_LABEL)
# Add our document type to the new index
self.index.document_types.add(self.document_type)
# Create simple index template
root = self.index.template_root
self.index.node_templates.create(
parent=root, expression=TEST_INDEX_TEMPLATE_DOCUMENT_LABEL_EXPRESSION,
link_documents=True
)
# Rebuild indexes
if rebuild:
Index.objects.rebuild()
self.test_index.refresh_from_db()
self.assertEqual(self.test_index.label, TEST_INDEX_LABEL_EDITED)
def _request_index_instance_node_view(self, index_instance_node):
return self.get(
'indexing:index_instance_node_view', args=(index_instance_node.pk,)
viewname='indexing:index_instance_node_view', kwargs={
'pk': index_instance_node.pk
}
)
def test_index_instance_node_view_no_permission(self):
self._create_index()
self._create_test_index()
response = self._request_index_instance_node_view(
index_instance_node=self.index.instance_root
index_instance_node=self.test_index.instance_root
)
self.assertEqual(response.status_code, 403)
def test_index_instance_node_view_with_access(self):
self._create_index()
self._create_test_index()
self.grant_access(
permission=permission_document_indexing_instance_view,
obj=self.index
obj=self.test_index,
permission=permission_document_indexing_instance_view
)
response = self._request_index_instance_node_view(
index_instance_node=self.index.instance_root
index_instance_node=self.test_index.instance_root
)
self.assertContains(response, text=TEST_INDEX_LABEL, status_code=200)
def _request_index_rebuild_get_view(self):
@@ -156,36 +133,41 @@ class IndexViewTestCase(GenericDocumentViewTestCase):
def _request_index_rebuild_post_view(self):
return self.post(
viewname='indexing:rebuild_index_instances', data={
'index_templates': self.index.pk
'index_templates': self.test_index.pk
}
)
def test_index_rebuild_no_permission(self):
self._create_index(rebuild=False)
self._create_test_index(rebuild=False)
response = self._request_index_rebuild_get_view()
self.assertNotContains(response=response, text=self.index.label, status_code=200)
self.assertNotContains(
response=response, text=self.test_index.label, status_code=200
)
response = self._request_index_rebuild_post_view()
# No error since we just don't see the index
self.assertEqual(response.status_code, 200)
self.assertEqual(
self.index.instance_root.get_children_count(), 0
self.test_index.instance_root.get_children_count(), 0
)
def test_index_rebuild_with_access(self):
self._create_index(rebuild=False)
self._create_test_index(rebuild=False)
self.grant_access(
permission=permission_document_indexing_rebuild, obj=self.index
obj=self.test_index,
permission=permission_document_indexing_rebuild
)
response = self._request_index_rebuild_get_view()
self.assertContains(response=response, text=self.index.label, status_code=200)
self.assertContains(
response=response, text=self.test_index.label, status_code=200
)
response = self._request_index_rebuild_post_view()
self.assertEqual(response.status_code, 302)
# An instance root exists
self.assertTrue(self.index.instance_root.pk)
self.assertTrue(self.test_index.instance_root.pk)