Fixed clang-tidy warnings

src/sequence_diagram/generators/json/sequence_diagram_generator.cc

@@ -48,7 +48,7 @@ void to_json(nlohmann::json &j, const activity &c)
     j["participant_id"] = std::to_string(c.from());
 }
 
-} // namespace clanguml::class_diagram::model
+} // namespace clanguml::sequence_diagram::model
 
 namespace clanguml::sequence_diagram::generators::json {
 
@@ -172,11 +172,8 @@ void generator::generate_call(const message &m, nlohmann::json &parent) const
         m.from(), to, m.to());
 }
 
-void generator::generate_activity(
-    common::model::diagram_element::id_t activity_id, const activity &a,
-    nlohmann::json &unused,
-    std::vector<common::model::diagram_element::id_t> &visited,
-    std::optional<nlohmann::json> nested_block) const
+void generator::generate_activity(const activity &a,
+    std::vector<common::model::diagram_element::id_t> &visited) const
 {
     // Generate calls from this activity to other activities
     for (const auto &m : a.messages()) {
@@ -265,8 +262,7 @@ void generator::process_call_message(const model::message &m,
             LOG_DBG("Creating activity {} --> {} - missing sequence {}",
                 m.from(), m.to(), m.to());
 
-            generate_activity(m.to(), m_model.get_activity(m.to()),
-                current_block_statement(), visited, {});
+            generate_activity(m_model.get_activity(m.to()), visited);
         }
     }
     else
@@ -644,8 +640,8 @@ void generator::generate(std::ostream &ostr) const
 
             block_statements_stack_.push_back(std::ref(sequence));
 
-            generate_activity(start_from, m_model.get_activity(start_from),
-                sequence, visited_participants, {});
+            generate_activity(
+                m_model.get_activity(start_from), visited_participants);
 
             json_["sequences"].push_back(std::move(sequence));
 
@@ -666,4 +662,4 @@ void generator::generate(std::ostream &ostr) const
 
     ostr << json_;
 }
-} // namespace clanguml::sequence_diagram::generators::plantuml
+} // namespace clanguml::sequence_diagram::generators::json

src/sequence_diagram/generators/json/sequence_diagram_generator.h

@@ -53,10 +53,8 @@ public:
     void generate_participant(
         nlohmann::json &parent, const std::string &name) const;
 
-    void generate_activity(common::model::diagram_element::id_t activity_id,
-        const sequence_diagram::model::activity &a, nlohmann::json &parent,
-        std::vector<common::model::diagram_element::id_t> &visited,
-        std::optional<nlohmann::json> nested_block) const;
+    void generate_activity(const sequence_diagram::model::activity &a,
+        std::vector<common::model::diagram_element::id_t> &visited) const;
 
     void generate(std::ostream &ostr) const override;
 

src/sequence_diagram/model/participant.cc

@@ -185,7 +185,7 @@ std::string method::message_name(message_render_mode mode) const
 {
     constexpr auto kAbbreviatedMethodArgumentsLength{15};
 
-    const std::string style = "";
+    const std::string style{};
 
     if (mode == message_render_mode::no_arguments) {
         return fmt::format("{}{}(){}{}", style, method_name(),

src/sequence_diagram/visitor/translation_unit_visitor.cc

@@ -1606,8 +1606,13 @@ translation_unit_visitor::build_template_instantiation_process_type_argument(
 
     // If this is a nested template type - add nested templates as
     // template arguments
-    if (arg.getAsType()->getAs<clang::FunctionType>() != nullptr) {
+    if (const auto *function_template_type =
+            arg.getAsType()->getAs<clang::FunctionType>();
+        function_template_type != nullptr) {
         // TODO
+        argument = template_parameter::make_argument(
+            common::to_string(function_template_type->getReturnType(),
+                template_decl->getASTContext()));
     }
     else if (const auto *nested_template_type =
                  arg.getAsType()->getAs<clang::TemplateSpecializationType>();