Fixed clang-tidy warnings

src/common/model/diagram.h

@@ -65,7 +65,7 @@ public:
      * @return Optional reference to a diagram element.
      */
     virtual common::optional_ref<clanguml::common::model::diagram_element> get(
-        diagram_element::id_t id) const = 0;
+        common::id_t id) const = 0;
 
     /**
      * Return optional reference to a diagram_element by name and namespace.
@@ -152,10 +152,7 @@ public:
     // Disallow std::string overload
     bool should_include(const std::string &s) const = delete;
 
-    virtual bool has_element(const diagram_element::id_t /*id*/) const
-    {
-        return false;
-    }
+    virtual bool has_element(const common::id_t /*id*/) const { return false; }
 
     virtual bool should_include(
         const namespace_ &ns, const std::string &name) const;

src/common/model/diagram_element.cc

@@ -26,16 +26,16 @@ namespace clanguml::common::model {
 
 diagram_element::diagram_element() = default;
 
-diagram_element::id_t diagram_element::id() const { return id_; }
+common::id_t diagram_element::id() const { return id_; }
 
-void diagram_element::set_id(diagram_element::id_t id) { id_ = id; }
+void diagram_element::set_id(common::id_t id) { id_ = id; }
 
 std::optional<id_t> diagram_element::parent_element_id() const
 {
     return parent_element_id_;
 }
 
-void diagram_element::set_parent_element_id(diagram_element::id_t id)
+void diagram_element::set_parent_element_id(common::id_t id)
 {
     parent_element_id_ = id;
 }

src/common/model/diagram_element.h

@@ -39,8 +39,6 @@ namespace clanguml::common::model {
  */
 class diagram_element : public decorated_element, public source_location {
 public:
-    using id_t = int64_t;
-
     diagram_element();
 
     ~diagram_element() override = default;
@@ -55,14 +53,14 @@ public:
      *
      * @return Elements id.
      */
-    id_t id() const;
+    common::id_t id() const;
 
     /**
      * Set elements id.
      *
      * @param id Elements id.
      */
-    void set_id(id_t id);
+    void set_id(common::id_t id);
 
     /**
      * Get elements parent package id.
@@ -76,7 +74,7 @@ public:
      *
      * @param id Id of parent package.
      */
-    void set_parent_element_id(diagram_element::id_t id);
+    void set_parent_element_id(id_t id);
 
     /**
      * @brief Return elements' diagram alias.

src/common/model/diagram_filter.cc

@@ -595,8 +595,8 @@ tvl::value_t module_access_filter::match(
         access_.begin(), access_.end(), [&e](const auto &access) {
             if (access == module_access_t::kPublic)
                 return !e.module_private();
-            else
-                return e.module_private();
+
+            return e.module_private();
         });
 }
 

src/common/model/element_view.h

@@ -58,8 +58,7 @@ public:
      *
      * @return
      */
-    common::optional_ref<T> get(
-        clanguml::common::model::diagram_element::id_t id) const
+    common::optional_ref<T> get(clanguml::common::id_t id) const
     {
         for (const auto &e : elements_) {
             if (e.get().id() == id) {

src/common/model/path.cc

@@ -29,6 +29,9 @@ std::string to_string(const path_type pt)
         return "namespace";
     case path_type::kFilesystem:
         return "directory";
+    default:
+        assert(false);
+        return "";
     }
 }