matthias/clang-uml
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixed clang-tidy warnings

Browse Source
This commit is contained in:
Bartek Kryza
2023-11-12 23:32:31 +01:00
parent 35f45a07e6
commit 7d607848cc
4 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/common/generators/generators.cc
View File

@@ -58,7 +58,6 @@ void find_translation_units_for_diagrams(
} }
void render_diagram(const clanguml::common::generator_type_t generator_type, void render_diagram(const clanguml::common::generator_type_t generator_type,
const std::string &output_directory,
std::shared_ptr<config::diagram> diagram_config) std::shared_ptr<config::diagram> diagram_config)
{ {
std::string cmd; std::string cmd;
@@ -162,8 +161,7 @@ void generate_diagram_impl(const std::string &name,
} }
if (runtime_config.render_diagrams) { if (runtime_config.render_diagrams) {
render_diagram( render_diagram(generator_type, diagram);
generator_type, runtime_config.output_directory, diagram);
} }
} }
} }

2
src/common/generators/plantuml/generator.h
View File

@@ -234,7 +234,7 @@ inja::json generator<C, D>::element_context(const E &e) const
ctx["element"]["source"]["line"] = e.line(); ctx["element"]["source"]["line"] = e.line();
} }
const auto maybe_comment = e.comment(); const auto &maybe_comment = e.comment();
if (maybe_comment) { if (maybe_comment) {
ctx["element"]["comment"] = maybe_comment.value(); ctx["element"]["comment"] = maybe_comment.value();
} }

2
src/common/model/diagram_filter.cc
View File

@@ -670,7 +670,7 @@ void context_filter::initialize(const diagram &d) const
// Prepare effective_contexts_ // Prepare effective_contexts_
for (auto i = 0U; i < context_.size(); i++) { for (auto i = 0U; i < context_.size(); i++) {
effective_contexts_.push_back({}); effective_contexts_.push_back({}); // NOLINT
initialize_effective_context(d, i); initialize_effective_context(d, i);
} }
} }

2
src/sequence_diagram/generators/mermaid/sequence_diagram_generator.cc
View File

@@ -80,7 +80,7 @@ void generator::generate_message_comment(
if (comment_generated_from_note_decorators) if (comment_generated_from_note_decorators)
return; return;
if (auto &cmt = m.comment(); if (const auto &cmt = m.comment();
config().generate_message_comments() && cmt.has_value()) { config().generate_message_comments() && cmt.has_value()) {
ostr << indent(1) << "note over " << generate_alias(from.value()) ostr << indent(1) << "note over " << generate_alias(from.value())