Applying readability-simplify-boolean-expr clang-tidy fixes

This commit is contained in:
Bartek Kryza
2022-12-21 17:42:37 +01:00
parent 75db32fdeb
commit 6750365d54
4 changed files with 7 additions and 15 deletions

View File

@@ -86,11 +86,9 @@ bool template_parameter::is_variadic() const noexcept { return is_variadic_; }
bool template_parameter::is_specialization_of(
const template_parameter &ct) const
{
if ((ct.is_template_parameter() || ct.is_template_template_parameter()) &&
!is_template_parameter())
return true;
return false;
return (ct.is_template_parameter() ||
ct.is_template_template_parameter()) &&
!is_template_parameter();
}
void template_parameter::add_template_param(template_parameter &&ct)

View File

@@ -347,10 +347,7 @@ public:
auto inc = tvl::all_of(inclusive_.begin(), inclusive_.end(),
[this, &e](const auto &in) { return in->match(diagram_, e); });
if (tvl::is_undefined(inc) || tvl::is_true(inc))
return true;
return false;
return static_cast<bool>(tvl::is_undefined(inc) || tvl::is_true(inc));
}
private:

View File

@@ -38,7 +38,7 @@ inline value_t all_of(InputIterator first, InputIterator last, Predicate pred)
for (InputIterator it = first; it != last; it++) {
value_t m = pred(*it);
if (m.has_value()) {
if (m.value() == true) {
if (m.value()) {
res = true;
}
else {
@@ -59,7 +59,7 @@ inline value_t any_of(InputIterator first, InputIterator last, Predicate pred)
for (InputIterator it = first; it != last; it++) {
value_t m = pred(*it);
if (m.has_value()) {
if (m.value() == true) {
if (m.value()) {
res = true;
break;
}

View File

@@ -2125,10 +2125,7 @@ bool translation_unit_visitor::should_include(const clang::CallExpr *expr) const
return false;
const auto expr_file = expr->getBeginLoc().printToString(source_manager());
if (!diagram().should_include(common::model::source_file{expr_file}))
return false;
return true;
return diagram().should_include(common::model::source_file{expr_file});
}
bool translation_unit_visitor::should_include(