matthias/clang-uml
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixed clang-tidy warnings

Browse Source
This commit is contained in:
Bartek Kryza
2023-10-21 18:16:27 +02:00
parent 097beb830f
commit 4f43253c0d
6 changed files with 22 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/sequence_diagram/generators/json/sequence_diagram_generator.cc
View File

@@ -110,8 +110,8 @@ void generator::generate_call(const message &m, nlohmann::json &parent) const
msg["from"]["activity_id"] = std::to_string(from.value().id());
msg["to"]["activity_id"] = std::to_string(to.value().id());
msg["to"]["activity_name"] = to.value().full_name(false);
if (m.comment())
msg["comment"] = m.comment().value();
if (const auto &cmt = m.comment(); cmt.has_value())
msg["comment"] = cmt.value();
if (from.value().type_name() == "method") {
const auto &class_participant =

16
src/sequence_diagram/generators/mermaid/sequence_diagram_generator.cc
View File

@@ -80,17 +80,19 @@ void generator::generate_message_comment(
if (comment_generated_from_note_decorators)
return;
if (!config().generate_message_comments() || !m.comment())
return;
if (auto &cmt = m.comment();
config().generate_message_comments() && cmt.has_value()) {
ostr << indent(1) << "note over " << generate_alias(from.value()) << ": ";
ostr << indent(1) << "note over " << generate_alias(from.value())
<< ": ";
auto formatted_message = util::format_message_comment(
m.comment().value(), config().message_comment_width());
auto formatted_message = util::format_message_comment(
cmt.value(), config().message_comment_width());
util::replace_all(formatted_message, "\n", "<br/>");
util::replace_all(formatted_message, "\n", "<br/>");
ostr << formatted_message << '\n';
ostr << formatted_message << '\n';
}
}
void generator::generate_call(const message &m, std::ostream &ostr) const

2
src/sequence_diagram/visitor/translation_unit_visitor.h
View File

@@ -512,7 +512,7 @@ private:
std::optional<std::string> get_expression_comment(
const clang::SourceManager &sm, const clang::ASTContext &context,
const int64_t caller_id, const clang::Stmt *stmt);
int64_t caller_id, const clang::Stmt *stmt);
// Reference to the output diagram model
clanguml::sequence_diagram::model::diagram &diagram_;