matthias/clang-uml
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Applying bugprone-narrowing-conversions clang-tidy fixes

Browse Source
This commit is contained in:
Bartek Kryza
2022-12-21 18:05:45 +01:00
parent 5d8f31dbe6
commit 14128374ef
5 changed files with 13 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/class_diagram/generators/plantuml/class_diagram_generator.cc
View File

@@ -194,10 +194,14 @@ void generator::generate(const class_ &c, std::ostream &ostr) const
std::string destination;
try {
destination = r.destination();
auto target_element = m_model.get(r.destination());
if (!target_element.has_value())
throw error::uml_alias_missing{
fmt::format("Missing element in the model for ID: {}",
r.destination())};
destination = target_element.value().full_name(false);
// TODO: Refactor destination to a namespace qualified entity
// name
if (util::starts_with(destination, std::string{"::"}))
destination = destination.substr(2, destination.size());

5
src/class_diagram/visitor/translation_unit_visitor.cc
View File

@@ -1409,7 +1409,8 @@ std::unique_ptr<class_> translation_unit_visitor::
template_instantiation.set_name(template_decl->getNameAsString());
template_instantiation.set_namespace(ns);
template_instantiation.set_id(template_decl->getID() +
(std::hash<std::string>{}(full_template_specialization_name) >> 4));
static_cast<id_t>(
std::hash<std::string>{}(full_template_specialization_name) >> 4u));
build_template_instantiation_process_template_arguments(parent,
template_base_params,
@@ -1661,7 +1662,7 @@ void translation_unit_visitor::
const std::string &full_template_specialization_name,
const clang::TemplateDecl *template_decl)
{
auto arg_index = 0U;
auto arg_index = 0;
for (const auto &arg : template_args) {
const auto argument_kind = arg.getKind();
template_parameter argument;