Applied modernize-pass-by-value clang-tidy fixes

This commit is contained in:
Bartek Kryza
2022-12-20 22:40:15 +01:00
parent 0ce7b533f4
commit 1116c3ab67
12 changed files with 46 additions and 35 deletions

View File

@@ -18,13 +18,15 @@
#include "class_element.h"
#include <utility>
namespace clanguml::class_diagram::model {
class_element::class_element(common::model::access_t access,
const std::string &name, const std::string &type)
class_element::class_element(
common::model::access_t access, std::string name, std::string type)
: access_{access}
, name_{name}
, type_{type}
, name_{std::move(name)}
, type_{std::move(type)}
{
}

View File

@@ -29,8 +29,8 @@ namespace clanguml::class_diagram::model {
class class_element : public common::model::decorated_element,
public common::model::source_location {
public:
class_element(common::model::access_t scope, const std::string &name,
const std::string &type);
class_element(
common::model::access_t scope, std::string name, std::string type);
common::model::access_t access() const;
std::string name() const;

View File

@@ -20,11 +20,13 @@
#include "common/model/enums.h"
#include <common/model/namespace.h>
#include <utility>
namespace clanguml::class_diagram::model {
template_parameter::template_parameter(const std::string &type,
const std::string &name, const std::string &default_value, bool is_variadic)
: default_value_{default_value}
const std::string &name, std::string default_value, bool is_variadic)
: default_value_{std::move(default_value)}
, is_variadic_{is_variadic}
{
set_name(name);

View File

@@ -34,7 +34,7 @@ namespace clanguml::class_diagram::model {
class template_parameter {
public:
template_parameter(const std::string &type = "",
const std::string &name = "", const std::string &default_value = "",
const std::string &name = "", std::string default_value = "",
bool is_variadic = false);
template_parameter(const template_parameter &right) = default;