Force all and extra warnings as errors except for tests

src/common/generators/plantuml/generator.h

@@ -261,7 +261,7 @@ std::unique_ptr<DiagramModel> generate(
 
     diagram->set_complete(true);
 
-    return std::move(diagram);
+    return diagram;
 }
 
 template <typename C, typename D> void generator<C, D>::init_context()

src/common/model/diagram_element.h

@@ -42,7 +42,7 @@ public:
 
     std::string name() const { return name_; }
 
-    virtual std::string full_name(bool relative) const { return name(); }
+    virtual std::string full_name(bool /*relative*/) const { return name(); }
 
     std::vector<relationship> &relationships();
 

src/common/model/diagram_filter.cc

@@ -90,31 +90,31 @@ filter_visitor::filter_visitor(filter_t type)
 }
 
 tvl::value_t filter_visitor::match(
-    const diagram &d, const common::model::element &e) const
+    const diagram & /*d*/, const common::model::element & /*e*/) const
 {
     return {};
 }
 
 tvl::value_t filter_visitor::match(
-    const diagram &d, const common::model::relationship_t &r) const
+    const diagram & /*d*/, const common::model::relationship_t & /*r*/) const
 {
     return {};
 }
 
 tvl::value_t filter_visitor::match(
-    const diagram &d, const common::model::access_t &a) const
+    const diagram & /*d*/, const common::model::access_t & /*a*/) const
 {
     return {};
 }
 
 tvl::value_t filter_visitor::match(
-    const diagram &d, const common::model::namespace_ &ns) const
+    const diagram & /*d*/, const common::model::namespace_ & /*ns*/) const
 {
     return {};
 }
 
 tvl::value_t filter_visitor::match(
-    const diagram &d, const common::model::source_file &f) const
+    const diagram & /*d*/, const common::model::source_file & /*f*/) const
 {
     return {};
 }
@@ -160,7 +160,7 @@ namespace_filter::namespace_filter(
 }
 
 tvl::value_t namespace_filter::match(
-    const diagram &d, const namespace_ &ns) const
+    const diagram & /*d*/, const namespace_ &ns) const
 {
     if (ns.is_empty())
         return {};
@@ -169,7 +169,8 @@ tvl::value_t namespace_filter::match(
         [&ns](const auto &nsit) { return ns.starts_with(nsit) || ns == nsit; });
 }
 
-tvl::value_t namespace_filter::match(const diagram &d, const element &e) const
+tvl::value_t namespace_filter::match(
+    const diagram & /*d*/, const element &e) const
 {
     if (dynamic_cast<const package *>(&e) != nullptr) {
         return tvl::any_of(
@@ -193,7 +194,8 @@ element_filter::element_filter(filter_t type, std::vector<std::string> elements)
 {
 }
 
-tvl::value_t element_filter::match(const diagram &d, const element &e) const
+tvl::value_t element_filter::match(
+    const diagram & /*d*/, const element &e) const
 {
     return tvl::any_of(elements_.begin(), elements_.end(),
         [&e](const auto &el) { return e.full_name(false) == el; });
@@ -253,7 +255,7 @@ relationship_filter::relationship_filter(
 }
 
 tvl::value_t relationship_filter::match(
-    const diagram &d, const relationship_t &r) const
+    const diagram & /*d*/, const relationship_t &r) const
 {
     return tvl::any_of(relationships_.begin(), relationships_.end(),
         [&r](const auto &rel) { return r == rel; });
@@ -265,7 +267,8 @@ access_filter::access_filter(filter_t type, std::vector<access_t> access)
 {
 }
 
-tvl::value_t access_filter::match(const diagram &d, const access_t &a) const
+tvl::value_t access_filter::match(
+    const diagram & /*d*/, const access_t &a) const
 {
     return tvl::any_of(access_.begin(), access_.end(),
         [&a](const auto &access) { return a == access; });
@@ -349,7 +352,7 @@ paths_filter::paths_filter(filter_t type, const std::filesystem::path &root,
 }
 
 tvl::value_t paths_filter::match(
-    const diagram &d, const common::model::source_file &p) const
+    const diagram & /*d*/, const common::model::source_file &p) const
 {
     if (paths_.empty()) {
         return {};

src/common/model/diagram_filter.h

@@ -131,8 +131,8 @@ struct edge_traversal_filter : public filter_visitor {
     edge_traversal_filter(filter_t type, relationship_t relationship,
         std::vector<std::string> roots, bool forward = false)
         : filter_visitor{type}
-        , relationship_{relationship}
         , roots_{roots}
+        , relationship_{relationship}
         , forward_{forward}
     {
     }

src/common/model/element.h

@@ -55,7 +55,7 @@ public:
 
     const namespace_ &path() const { return ns_; }
 
-    std::string full_name(bool relative) const override
+    std::string full_name(bool /*relative*/) const override
     {
         return name_and_ns();
     }

src/common/model/relationship.cc

@@ -26,10 +26,10 @@ relationship::relationship(relationship_t type, const std::string &destination,
     const std::string &multiplicity_destination)
     : type_{type}
     , destination_{destination}
-    , access_{access}
-    , label_{label}
     , multiplicity_source_{multiplicity_source}
     , multiplicity_destination_{multiplicity_destination}
+    , label_{label}
+    , access_{access}
 {
 }
 

src/common/model/relationship.h

@@ -56,11 +56,11 @@ public:
     friend bool operator==(const relationship &l, const relationship &r);
 
 private:
-    relationship_t type_{relationship_t::kAssociation};
+    relationship_t type_;
     std::string destination_;
     std::string multiplicity_source_;
     std::string multiplicity_destination_;
     std::string label_;
-    access_t access_{access_t::kPublic};
+    access_t access_;
 };
 }

src/common/model/source_file.h

@@ -72,7 +72,7 @@ public:
 
     const filesystem_path &path() const { return path_; }
 
-    std::string full_name(bool relative) const override
+    std::string full_name(bool /*relative*/) const override
     {
         return (path_ | name()).to_string();
     }